8000 Failure details in sonar test reporter are now CDATA by jgebal · Pull Request #926 · utPLSQL/utPLSQL · GitHub
[go: up one dir, main page]
Skip to content

Failure details in sonar test reporter are now CDATA #926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 2, 2019
Merged

Failure details in sonar test reporter are now CDATA #926

merged 7 commits into from
Jun 2, 2019

Conversation

jgebal
Copy link
Member
@jgebal jgebal commented May 23, 2019 •
edited
Loading

Resolves #925
Resolves #927

@jgebal jgebal added the bugfix label May 23, 2019
@jgebal jgebal added this to the v3.1.7 milestone May 23, 2019
@jgebal jgebal self-assigned this May 23, 2019
@jgebal
Copy link
Member Author
jgebal commented May 25, 2019

@lwasylow I've replaced the test results failures with escaped CDATA blocks.
This is to avid the issue I've seen at work (quite rare but still annoying), where if failure message is longer than 4k an dbms_xmlgen.convert is used, the line can get split into two lines inside the escaped XML characters making the XML report impossible to parse.

Let me know if you're OK with this change.

@jgebal
Copy link
Member Author
jgebal commented May 25, 2019

Seems like sonar is complaining on code duplication.
Maybe we should have some base XML functions to avoid duplication?

@lwasylow
Copy link
Member

Yeah definitely change make sense. And I think moving some of duplicate code into utils type is a good idea. Less maintenance and possibility of bugs.

@jgebal jgebal merged commit 5b8f7bd into develop Jun 2, 2019
@jgebal jgebal deleted the feature/fix_sonar_test_reporter branch June 2, 2019 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lwasylow lwasylow lwasylow approved these changes

Assignees

@jgebal jgebal

Labels
bugfix
Projects
None yet
Milestone
v3.1.7
Development

Successfully merging this pull request may close these issues.

JUnit test results import fail Sonar test results fail on import.
2 participants
@jgebal @lwasylow
0