8000 Feature/two output buffers by jgebal · Pull Request #888 · utPLSQL/utPLSQL · GitHub
[go: up one dir, main page]
Skip to content

Feature/two output buffers #888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 1, 2019
Merged

Feature/two output buffers #888

merged 4 commits into from
Apr 1, 2019

Conversation

jgebal
Copy link
Member
@jgebal jgebal commented Mar 31, 2019

This feature will require changes on cli.
See: utPLSQL/utPLSQL-cli#140

jgebal added 4 commits March 30, 2019 20:58
@jgebal
Fixed storage for clob in output bugger table - make it inline.
7bae9ff 
Changed how delete from output buffer table is handled - use ROWID.
Increased fetch size from 100 to 3000 rows for output buffer.
@jgebal
9d6bfe8 
Decreased read limit back to 1000 as it should not have significant performance impact anymore.
@jgebal
Increased read limit to 5000.
4d00c33 
Fixed bug with increasing `max_message_id` even when nothing was read.
@jgebal
Split output buffers into two.
e1119c6 
Now we have separate buffer for CLOB data and VARCHAR2 text data.
@PhilippSalvisberg
Copy link
Member

I installed the branch feature/two_output_buffers in my local environment, run the tests and got the following result:

Finished in 79.545574 seconds
797 tests, 0 failed, 0 errored, 1 disabled, 0 warning(s)

I will need to adapt the current implementation for the SQL Developer extension on my branch issue_6 since I'm using this incompatible code:

SELECT t.item_type, t.text
  FROM table(ut_output_table_buffer(?).get_lines()) t

I'll change that to the way suggested in utPLSQL/utPLSQL-cli#140 - That is not a problem at all, especially since it is a development branch only.

I see this PR as a quick fix for the problems introduced with the change from VC2 to CLOB. However, I think we can do better in terms of API design (making it more narrow, less redundant and more independent of the implementation) without compromising performance. This can be addressed in dedicated issues and coming releases.

@PhilippSalvisberg PhilippSalvisberg mentioned this pull request Apr 1, 2019
Open
@PhilippSalvisberg PhilippSalvisberg merged commit b734f86 into develop Apr 1, 2019
@jgebal jgebal deleted the feature/two_output_buffers branch April 1, 2019 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilippSalvisberg PhilippSalvisberg PhilippSalvisberg approved these changes

@pesse pesse Awaiting requested review from pesse

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jgebal @PhilippSalvisberg
0