8000 fix(rspack): plugin.__vfs is undefined by thinke5 · Pull Request #439 · unjs/unplugin · GitHub
[go: up one dir, main page]
Skip to content

fix(rspack): plugin.__vfs is undefined #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ahabhgk merged 1 commit into from
Nov 28, 2024
Merged

fix(rspack): plugin.__vfs is undefined #439

ahabhgk merged 1 commit into from
Nov 28, 2024

Conversation

@thinke5
Copy link
Contributor
@thinke5 thinke5 commented Nov 28, 2024

fix

        plugin.__vfs.writeModule(id, code);
                     ^

TypeError: Cannot read properties of undefined (reading 'writeModule')

@sxzz
Copy link
Member
sxzz commented Nov 28, 2024

/cc @ahabhgk

@pkg-pr-new
Copy link
pkg-pr-new bot commented Nov 28, 2024

Open in Stackblitz

npm i https://pkg.pr.new/unjs/unplugin@439

commit: 0341781

ahabhgk
ahabhgk approved these changes Nov 28, 2024
View reviewed changes
Copy link
Collaborator
@ahabhgk ahabhgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ahabhgk ahabhgk merged commit 3c4b79e into unjs:main Nov 28, 2024
15 checks passed
@taylor-wu-appier taylor-wu-appier mentioned this pull request Jan 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahabhgk ahabhgk ahabhgk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thinke5 @sxzz @ahabhgk
0