8000 Make formatting more consistent by pjohnmeyer · Pull Request #93 · unittest-cpp/unittest-cpp · GitHub
[go: up one dir, main page]
Skip to content

Make formatting more consistent #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 30, 2016
Merged

Make formatting more consistent #93

merged 3 commits into from
Jan 30, 2016

Conversation

pjohnmeyer
Copy link
Member

This still isn't perfect, but I threw together a quick uncrustify configuration that did most of the work, and then hand-tweaked a few things as well. Three-space indentation, no more tabs. Some of this will likely change later when I develop the contributing guidelines.

@pjohnmeyer pjohnmeyer added this to the 1.5.1 milestone Jan 30, 2016
pjohnmeyer added a commit that referenced this pull request Jan 30, 2016
@pjohnmeyer
Merge pull request #93 from unittest-cpp/uncrustify
6bfab53 
Make formatting more consistent
@pjohnmeyer pjohnmeyer merged commit 6bfab53 into master Jan 30, 2016
@pjohnmeyer pjohnmeyer deleted the uncrustify branch January 30, 2016 05:09
@grahamreeds
Copy link
Contributor

Three spaces? Why three?

Sent from my Nexus 5.
On 30 Jan 2016 5:06 a.m., "Patrick Johnmeyer" notifications@github.com
wrote:

This still isn't perfect, but I threw together a quick uncrustify
configuration that did most of the work, and then hand-tweaked a few things
as well. Three-space indentation, no more tabs. Some of this will likely

change later when I develop the contributing guidelines.

You can view, comment on, or merge this pull request online at:

#93
Commit Summary

  • Add uncrustify config and run first pass.
  • Change preprocessor indent rules.
  • Tweak preprocessor blocks.

File Changes

Patch Links:

—
Reply to this email directly or view it on GitHub
#93.

@pjohnmeyer
Copy link
Member Author

I rolled a d20 and that's what came up. That was a nervous moment, let me tell you. :)

In other words, I picked a rule so that it would be something.

@hymerman
Copy link
Contributor
hymerman commented Feb 1, 2016

"19 spaces?! Nooooooooo!"

I can personally only remember one other project using 3 spaces in the last 10 years - Graham's right, it is a bit weird :)

@pjohnmeyer
Copy link
Member Author

I used it for half of my career, when I was still doing C++ in m 760F y day job. I'm okay with being weird.

¯\_(ツ)_/¯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.5.1
Development

Successfully merging this pull request may close these issues.
3 participants
@pjohnmeyer @grahamreeds @hymerman
0