8000 Vs2015 support by annagrin · Pull Request #78 · unittest-cpp/unittest-cpp · GitHub
[go: up one dir, main page]
Skip to content

Vs2015 support #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 16, 2015
Merged

Vs2015 support #78

merged 1 commit into from
Oct 16, 2015

Conversation

annagrin
Copy link
Contributor

Changes to support unittests in GSL library - addressing issue #79

  • Added checks for compilers supporting c++11.
  • Defined out the _NOEXCEPT for compiler versions that do not support the noexcept keyword
  • Worked around a dependency on non-portable behavior regarding the lifetimes of temporaries to ensure the line number gets added to the report of a failing test

@pjohnmeyer
Copy link
Member

@annagrin @neilmacintosh are you looking at fixing the build problems? They appear to be CMake related.

@annagrin
Copy link
Contributor Author

Yes, thanks!

@annagrin
Copy link
Contributor Author

all build problems are fixed.

@annagrin
Copy link
Contributor Author
annagrin commented Oct 9, 2015

@pjohnmeyer Would it be possible to merge the GSL-related PR? That would free us and other GSL users from using Microsoft fork of the unittests. Please let me know if there are any issues that need to be addressed. You help is greatly appreciated. Thanks, Anna

@neilmacintosh
Copy link

@pjohnmeyer is there anything more we can do to this PR to make it acceptable? We'd love to no longer require users of the GSL library to use our fork of unittest-cpp.

@pjohnmeyer
Copy link
Member

@neilmacintosh It looks okay at a glance so I'll pull it in and take a closer look later.

pjohnmeyer added a commit that referenced this pull request Oct 16, 2015
@pjohnmeyer
Merge pull request #78 from Microsoft/vs2015Support
dc6b908 
Vs2015 support
@pjohnmeyer pjohnmeyer merged commit dc6b908 into unittest-cpp:master Oct 16, 2015
@neilmacintosh
Copy link

Thanks @pjohnmeyer, much appreciated!

From: Patrick Johnmeyermailto:notifications@github.com
Sent: ‎10/‎15/‎2015 8:20 PM
To: unittest-cpp/unittest-cppmailto:unittest-cpp@noreply.github.com
Cc: Neil MacIntoshmailto:Neil.MacIntosh@microsoft.com
Subject: Re: [unittest-cpp] Vs2015 support (#78)

@neilmacintoshhttps://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithub.com%2fneilmacintosh&data=01%7c01%7cNeil.MacIntosh%40microsoft.com%7c0571eed8341c4316a5fc08d2d5d8b8b4%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=c8k0h7tP3gVYlfgGf6ASgeVdZ5MOffHDeiTjpWW2oT0%3d It looks okay at a glance so I'll pull it in and take a closer look later.

—
Reply to this email directly or view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithub.com%2funittest-cpp%2funittest-cpp%2fpull%2f78%23issuecomment-148588396&data=01%7c01%7cNeil.MacIntosh%40microsoft.com%7c0571eed8341c4316a5fc08d2d5d8b8b4%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=CEIY0FDKvN72b2FQTyZIs5krByu0T00EaiKTdcKoi3M%3d.

@pjohnmeyer pjohnmeyer mentioned this pull request Nov 3, 2015
Closed
@pjohnmeyer pjohnmeyer modified the milestone: 2.0.0 Jan 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@annagrin @pjohnmeyer @neilmacintosh
0