10000 Take UnitTest::Check parameter by const reference by pjohnmeyer · Pull Request #120 · unittest-cpp/unittest-cpp · GitHub
[go: up one dir, main page]

Skip to content

Take UnitTest::Check parameter by const reference #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 17, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion UnitTest++/Checks.h
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ namespace UnitTest {


template< typename Value >
bool Check(Value const value)
bool Check(Value const& value)
{
return !!value; // doing double negative to avoid silly VS warnings
}
Expand Down
28 changes: 28 additions & 0 deletions tests/TestChecks.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -315,4 +315,32 @@ namespace {
CHECK_EQUAL(1234, reporter.lastFailedLine);
}

class TruthyUnlessCopied
{
public:
TruthyUnlessCopied()
: truthy_(true)
{
}

TruthyUnlessCopied(const TruthyUnlessCopied&)
: truthy_(false)
{
}

operator bool() const
{
return truthy_;
}

private:
bool truthy_;
};

TEST(CheckProperlyDealsWithOperatorBoolOverrides)
{
TruthyUnlessCopied objectThatShouldBeTruthy;
CHECK(objectThatShouldBeTruthy);
}

}
0