Prefix local variable message in CHECK macros with UnitTest_ #116
Conversation
…e the risk of name collisions with application code
|
I'm not entirely sure what the whitespace conventions are for this project, so I've compensated for the increase in variable length when changing from message to UnitTest_message by removing nine of the trailing spaces in each case. |
|
Sorry for the long delay. I have no problem with the changes and I'm going to merge this pull, but I'm curious what the "risk of name collisions" is? If I'm not mistaken, the variables are in their own scopes and should be hiding variables of the same name in user code. If you don't mind, I'd like to know the problem you had as a result of the name collision. |
|
Hey, Thanks for merging. Iirc it was to placate MSVC warning about one variable (hiding|shadowing) another. Editing the macro was preferable to dropping the variable shadowing warning as it found an interesting bug elsewhere in our code. I don't remember gcc or clang complaining, but I might be wrong about that. Thanks |
|
That's what I expected. Knowing this might inform a "better" solution somewhere down the line. Thanks for the PR! |
to reduce the risk of name collisions with application code