autoconf & automake improvements #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 7, 2016 14:55
Making the comments more explicative and less opinionated. :)
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there!
Sorry I haven't been around very much. I've been extremely busy with real life and my day job.
I understand you were asking some questions about the autoconf / automake build scripts before the release earlier, but I haven't been able to get to any of my projects using unittest-cpp until now.
However, I've currently switched my build environment from Cygwin to Mingw64+Msys2 and have noticed that the previous Windows $host detection checks in configure.ac were no longer working in the new environment.
I did some reading, and found the
AC_CANONICAL_HOSTautoconf directive, which usesconfig.guessto figure out the compiler's OS and architecture, and populates the $host variable for systems like msys2, which do not do so by default.I also took the liberty of fixing issue #105, wherein
make installinstalls unittest-cpp headers to/usr/include/UnitTest++/UnitTest++/(which was obviously not my intention; I just never install it system-wide and I guess I forgot to test it...)