8000 Fixed retext-english usage by zikunw · Pull Request #44 · unifiedjs/unifiedjs.github.io · GitHub
[go: up one dir, main page]

Skip to content

Fixed retext-english usage #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fixed retext-english usage #44

wants to merge 1 commit into from

Conversation

zikunw
Copy link
@zikunw zikunw commented Sep 3, 2023

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

retext-english now provides a Parser object. The previous code will not run with the current version of retest-english, which will trigger the warning TypeError: Cannot call a class constructor without |new| in runtime.

The solution is import the Parser object from the package and use it instead when generating the syntax tree.

retext-english now provides a Parser object. The previous code will not run with the current version.
@wooorm
A444 Copy link
Member
wooorm commented Sep 24, 2023

Sorry for the wait, thanks for your patience.

I’ve been working on the releases. The parsers are now no longer exported.

I think you can get it from the parse-english package. Could you try updating to that?

@wooorm
Copy link
Member
wooorm commented Aug 16, 2024

Thanks for your patience.

I rewrote all guides in 97178c6. See it live here!

@wooorm wooorm closed this Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0