8000 Minimum support Rust version changed with 1.2.0 · Issue #26 · unicode-rs/unicode-segmentation · GitHub
[go: up one dir, main page]
Skip to content

Minimum support Rust version changed with 1.2.0 #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mgeisler opened this issue May 22, 2017 · 0 comments
Closed

Minimum support Rust version changed with 1.2.0 #26

mgeisler opened this issue May 22, 2017 · 0 comments

Comments

@mgeisler
Copy link
Contributor

Hi all,

I wanted to contribute some code to clap, and got an unexpected build failure. I believe I've traced it back to the newly released unicode-segmentation version 1.2.0, which include code using the ? operator. That is, clap is testng with Rust 1.11.0 and the ? operator was stabilized in Rust 1.13.0 -- hence the build failure.

I searched on the users forum and found some discussions about how to handle changes in the minimum supported Rust version -- some seemed to think it should require a major version bump, others did not.

So while there seems to be no best practice here yet, I just wanted to make you aware of the change :-) Would you be interested in extending our Travis config to test with a known-good minimum supported Rust version? I suppose that will be 1.13.0 at the moment.

The clap issue: clap-rs/clap#845 (comment).
The commit that introduced the ? operator: aaf9da4#diff-dd3463da52dddbc4cbf510ba1b8c1fd2R715.
@mgeisler mgeisler mentioned this issue May 23, 2017
Merged
mgeisler added a commit to mgeisler/unicode-segmentation that referenced this issue May 23, 2017
@mgeisler
travis: also test with minimum supported Rust version
7f5045c 
The 1.2.0 release increased the minimum supported version of Rust from
below 1.11.0 to 1.13.0 due to the introduction of code that use the
"?" operator. This caused unexpected build failures in dependent
crates, such as clap.

This PR updates Travis to also test against the current minimum
version. Changes to this version will thus fail PRs and it will become
an active decision to bump the minimum supported Rust version.

Fixes unicode-rs#26.
@mgeisler mgeisler mentioned this issue May 23, 2017
Merged
mgeisler added a commit to mgeisler/unicode-segmentation that referenced this issue May 23, 2017
@mgeisler
travis: also test with minimum supported Rust version
3d00c94 
The 1.2.0 release increased the minimum supported version of Rust from
below 1.11.0 to 1.13.0 due to the introduction of code that use the
"?" operator. This caused unexpected build failures in dependent
crates, such as clap.

This PR updates Travis to also test against the current minimum
version. Changes to this version will thus fail PRs and it will become
an active decision to bump the minimum supported Rust version.

Fixes unicode-rs#26.
homu added a commit to clap-rs/clap that referenced this issue May 28, 2017
@homu
Auto merge of #967 - mgeisler:restrict-unicode-segmentation-version, …
a0cad8d 
…r=kbknapp

cargo: restrict unicode-segmentation to ~1.1.0

Version 1.2.0 of unicode-segmentation adds code that use the "?"
operator, which in turn requires Rust 1.13.0. However, clap currently
still works with Rust 1.11.0 and this caused build failures:

  https://travis-ci.org/kbknapp/clap-rs/jobs/235010822

The changes since 1.1.0 seem to be related cursors/iterators and I
think clap can work fine without them.

This was found as part of #845. See also unicode-rs/unicode-segmentation#26.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/kbknapp/clap-rs/967)
<!-- Reviewable:end -->
mgeisler added a commit to mgeisler/unicode-segmentation that referenced this issue Mar 30, 2019
@mgeisler
travis: also test with minimum supported Rust version
b763059 
The 1.2.0 release increased the minimum supported version of Rust from
below 1.11.0 to 1.13.0 due to the introduction of code that use the
"?" operator. This caused unexpected build failures in dependent
crates, such as clap.

This PR updates Travis to also test against the current minimum
version. Changes to this version will thus fail PRs and it will become
an active decision to bump the minimum supported Rust version.

Fixes unicode-rs#26.
mgeisler added a commit to mgeisler/unicode-segmentation that referenced this issue Mar 30, 2019
@mgeisler
travis: also test with minimum supported Rust version
7532142 
The 1.2.0 release increased the minimum supported version of Rust from
below 1.11.0 to 1.13.0 due to the introduction of code that use the
"?" operator. This caused unexpected build failures in dependent
crates, such as clap.

This PR updates Travis to also test against the current minimum
version. Changes to this version will thus fail PRs and it will become
an active decision to bump the minimum supported Rust version.

Between the commit was originally made and today, the minimum version
increased further and the earliest version where I can get the crate
to compile is now Rust 1.24.0.

Fixes unicode-rs#26.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mgeisler
0