Impl pretty-printing for AugmentedScriptSet #19

crlf0710 · 2020-06-10T02:33:23Z

Manishearth · 2020-06-10T02:49:44Z

src/mixed_script.rs

+impl Debug for AugmentedScriptSet {
+    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
+        if self.is_empty() {
+            write!(f, "AugmentedScriptSet{{∅}}")?;


Can we have a space after the name?

Manishearth · 2020-06-10T02:50:42Z

src/mixed_script.rs

+            let hanb = if self.hanb { Some("Hanb") } else { None };
+            let jpan = if self.jpan { Some("Jpan") } else { None };
+            let kore = if self.kore { Some("Kore") } else { None };
+            for writing_system in None.into_iter().chain(hanb).chain(jpan).chain(kore) {


we can just chain an base.iter.map(Script::short_name) here

Indeed! Thanks

Manishearth · 2020-06-10T02:51:17Z

src/mixed_script.rs

+            //for script in self.hanb
+            write!(f, "}}")?;
+        }
+        //if self.base.is_common() || self.base.is_


Remove the comments

Manishearth · 2020-06-10T02:52:19Z

src/restriction_level.rs

@@ -58,13 +58,21 @@ impl RestrictionLevelDetection for &'_ str {
            }
        }

+        fn single_item<I: Iterator>(mut iter: I) -> Option<I::Item> {


Can we instead implement this via count_ones()?

Do you mean accessing the bitset underlying ScriptExtension directly? We cannot access the implementation detail from this crate...

Right, add that to the original crate. Maybe a len() method

unicode-rs/unicode-script#4

The PR is merged, now we need a new release of that crate.

Manishearth · 2020-06-10T02:52:43Z

src/mixed_script.rs

@@ -67,14 +65,50 @@ impl From<&'_ str> for AugmentedScriptSet {
 impl Default for AugmentedScriptSet {
    fn default() -> Self {
        AugmentedScriptSet {
-            base: ScriptExtension::Single(Script::Common),
+            base: ScriptExtension::from(Script::Common),


nit: I prefer .into()

crlf0710 · 2020-06-12T05:03:19Z

Manishearth reviewed Jun 10, 2020

View reviewed changes

crlf0710 added 2 commits June 12, 2020 13:00

Upgrade to unicode-script 0.5.1

e8a8e16

Implement pretty-print for augumented script set.

a5d5f09

crlf0710 force-pushed the impl_debug branch from 8c35245 to a5d5f09 Compare June 12, 2020 05:02

crlf0710 mentioned this pull request Jun 12, 2020

Upgrade to unicode-script 0.5.0 #18

Closed

Manishearth merged commit 1d0a740 into unicode-rs:master Jun 12, 2020

crlf0710 deleted the impl_debug branch June 12, 2020 16:06

This was referenced Jun 12, 2020

Add a way to pretty print AugmentScriptSet. #16

Closed

404 for documentation #14

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Impl pretty-printing for AugmentedScriptSet #19

Impl pretty-printing for AugmentedScriptSet #19

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Impl pretty-printing for AugmentedScriptSet #19

Impl pretty-printing for AugmentedScriptSet #19

Uh oh!

Conversation

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!