8000 Fix one instance of non-https curl by mrluc · Pull Request #12 · unicode-rs/unicode-script · GitHub
[go: up one dir, main page]
Skip to content

Fix one instance of non-https curl #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 22, 2021
Merged

Fix one instance of non-https curl #12

merged 1 commit into from
Nov 22, 2021

Conversation

mrluc
Copy link
Contributor
@mrluc mrluc commented Nov 22, 2021

http -> https cleanup similar to a recent unicode-security pr; a comment in that repo's unicode.py hinted that this repo had a similar script

unicode-script/scripts/unicode.py

Lines 58 to 63 in 974eb90

if "emoji" in f:
os.system("curl -O https://www.unicode.org/Public/emoji/%s.%s/%s"
% (UNICODE_VERSION[0], UNICODE_VERSION[1], f))
else:
os.system("curl -O http://www.unicode.org/Public/%s/ucd/%s"
% (UNICODE_VERSION_NUMBER, f))

(apologies if these are noisy, I know they're not very substantive)

@Manishearth Manishearth merged commit 683ae04 into unicode-rs:master Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrluc @Manishearth
0