Update to Unicode 14 #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello. I'm sorry if this comes across as a drive-by PR. It was either this, or open an issue, and I figured I may as well try.
The changes made are minimal. I updated the Python script to refer to Unicode version 14; ran the script; and moved the resulting files to their places. Running
cargo testafter this resulted in one error: a check that code point U+FDCF is unassigned. Unicode 14 has assigned it to an Arabic ligature (سلامه علينا). So I removed that specific test. Everything else seems to be passing.I'm not sure if more is involved in updating this library to a new version of Unicode. The PR that brought it to version 13 was similarly simple. Thanks for your maintainership!