Migrate normalization tests to test/ to simplify pruning tests during shipping. #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leaves all other tests in place. Provides a #[doc(hidden)] shim for accessing/using otherwise private members from tests/
- Unify all tests/ into a single file to reduce the number of output targets during `cargo test` - This also avoids double-compiling the normalization_tests.rs - Move normalization_tests.rs to be a child of tests/data/ to avoid getting compiled as a test unit, and further removing useless output from cargo test
Leaving integrated bundled tests working.
I haven't done this part yet, for 2 reasons:
diff --git a/src/tables.rs b/src/tables.rs
index 960a94f..f92898d 100644
--- a/src/tables.rs
+++ b/src/tables.rs
@@ -19217,6 +19217,7 @@ pub(crate) const COMBINING_MARK_KV: &[u32] = &[
#[inline]
+#[allow(ellipsis_inclusive_range_patterns)]
pub fn qc_nfc(c: char) -> IsNormalized {
match c {
'\u{0340}'...'\u{0341}' => No,
@@ -19340,6 +19341,7 @@ pub fn qc_nfc(c: char) -> IsNormalized {
}
#[inline]
+#[allow(ellipsis_inclusive_range_patterns)]
pub fn qc_nfkc(c: char) -> IsNormalized {
match c {
'\u{00A0}' => No,
@@ -19776,6 +19778,7 @@ pub fn qc_nfkc(c: char) -> IsNormalized {
}
#[inline]
+#[allow(ellipsis_inclusive_range_patterns)]
pub fn qc_nfd(c: char) -> IsNormalized {
match c {
'\u{00C0}'...'\u{00C5}' => No,
@@ -20025,6 +20028,7 @@ pub fn qc_nfd(c: char) -> IsNormalized {
}
#[inline]
+#[allow(ellipsis_inclusive_range_patterns)]
pub fn qc_nfkd(c: char) -> IsNormalized {
match c {
'\u{00A0}' => No, |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #38