Rework tests for better consumer visibility. #43
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch moves as many tests as viable to tests/, in order to make nuking "non-critical" code easier. ( Nothing will hurt if you nuke tests/*, just you won't have as many tests ) All tests that require src/normalization_tests.rs are gated by ```rust #[cfg(bloaty_test)] ``` So that they only run when invoked as: RUSTFLAGS="--cfg bloaty_test" cargo test If you do this, its your reponsibility to make sure that file is there. This means nuking src/normalization_tests.rs doesn't break what happens by default when a consumer runs `cargo test` in a published crate. One tests that previously lived in its own file was folded back into src/lib.rs, because it was more concise that way, and after the migration to tests/, it was pretty much there on its own, not warranting an individual file.
|
I'm sorry, putting the main tests out of the happy path is not a viable solution here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch moves as many tests as viable to tests/, in order to make
nuking "non-critical" code easier.
( Nothing will hurt if you nuke tests/*, just you won't have as many
tests )
All tests that require src/normalization_tests.rs are gated by
#[cfg(bloaty_test)]So that they only run when invoked as:
RUSTFLAGS="--cfg bloaty_test" cargo test
If you do this, its your reponsibility to make sure that file is there.
This means nuking src/normalization_tests.rs doesn't break what happens
by default when a consumer runs
cargo testin a published crate.One tests that previously lived in its own file was folded back
into src/lib.rs, because it was more concise that way, and after the
migration to tests/, it was pretty much there on its own, not
warranting an individual file.
Closes: #38