8000 impl UnicodeNormalization for char [enhancement] · Issue #75 · unicode-rs/unicode-normalization · GitHub
[go: up one dir, main page]
Skip to content
8000

impl UnicodeNormalization for char [enhancement] #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
BartMassey opened this issue Apr 10, 2021 · 2 comments
Closed

impl UnicodeNormalization for char [enhancement] #75

BartMassey opened this issue Apr 10, 2021 · 2 comments

Comments

@BartMassey
Copy link
BartMassey commented Apr 10, 2021 •
edited
Loading

As far as I can tell, right now the only way to get a char normalized is to convert it into a String first, then "iterate" over it. This is a bit awkward and inefficient. It would be nice to have UnicodeNormalization implemented for char.

The UnicodeNormalization trait looks fine for this: you still need to produce an iterator because a single char might normalize to multiple chars.

The project looks big enough that I'm not going to try a pull request myself without some feedback. It looks like the normalize module provides the necessary functions, so I guess it's mostly just typing it in?
@Manishearth
Copy link
Member

I think this would be fine

Manishearth added a commit that referenced this issue Oct 8, 2021
@Manishearth
Merge pull request #82 from Xaeroxe/fix-75
68f2f55 
Fix #75, implement UnicodeNormalization for char
@BartMassey
Copy link
Author

Thank you @Manishearth !! I kept meaning to get back to this, but never did. Really appreciate your picking it up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@BartMassey @Manishearth
0