8000 bpo-30989: Sort in TimedRotatingFileHandler only when needed. (GH-2812) · ultimatecoder/cpython@afad147 · GitHub
[go: up one dir, main page]

Skip to content

Commit afad147

Browse files
loveshvsajip
authored andcommitted
bpo-30989: Sort in TimedRotatingFileHandler only when needed. (pythonGH-2812)
TimedRotatingFileHandler.getFilesToDelete() now sorts only when needed.
1 parent d609b0c commit afad147

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Lib/logging/handlers.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -353,10 +353,10 @@ def getFilesToDelete(self):
353353
suffix = fileName[plen:]
354354
if self.extMatch.match(suffix):
355355
result.append(os.path.join(dirName, fileName))
356-
result.sort()
357356
if len(result) < self.backupCount:
358357
result = []
359358
else:
359+
result.sort()
360360
result = result[:len(result) - self.backupCount]
361361
return result
362362

0 commit comments

Comments
 (0)
0