8000 bpo-30989: Sort in TimedRotatingFileHandler only when needed. by lovesh · Pull Request #2812 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-30989: Sort in TimedRotatingFileHandler only when needed. #2812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 27, 2017
Merged

bpo-30989: Sort in TimedRotatingFileHandler only when needed. #2812

merged 1 commit into from
Oct 27, 2017

Conversation

lovesh
Copy link
Contributor
@lovesh lovesh commented Jul 22, 2017 •
edited by bedevere-bot
Loading

TimedRotatingFileHandler's getFilesToDelete should sort only when len(result) > backupCount

https://bugs.python.org/issue30989

Sort in TimedRotatingFileHandler only when needed.
c63876a < 8000 /div> 
TimedRotatingFileHandler's getFilesToDelete should sort only when `len(result)` > backupCount
@mention-bot
Copy link

@lovesh, thanks for your PR! By analyzing the history of the files in this pull request, we identified @vsajip, @benjaminp and @nnorwitz to be potential reviewers.

@python python deleted a comment from the-knights-who-say-ni Jul 24, 2017
@vsajip vsajip merged commit afad147 into python:master Oct 27, 2017
@miss-islington
Copy link
Contributor

Thanks @lovesh for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 19, 2017
@lovesh @miss-islington
bpo-30989: Sort in TimedRotatingFileHandler only when needed. (python…
0325a09 
…GH-2812)

TimedRotatingFileHandler.getFilesToDelete() now sorts only when needed.
(cherry picked from commit afad147)
@bedevere-bot
Copy link

GH-4466 is a backport of this pull request to the 3.6 branch.

vsajip pushed a commit that referenced this pull request Nov 19, 2017
@miss-islington @vsajip
bpo-30989: Sort in TimedRotatingFileHandler only when needed. (GH-2812)…
65dffe5 
… (GH-4466)

TimedRotatingFileHandler.getFilesToDelete() now sorts only when needed.
(cherry picked from commit afad147)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsajip vsajip vsajip approved these changes

@rhettinger rhettinger rhettinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@lovesh @mention-bot @miss-islington @bedevere-bot @vsajip @rhettinger @the-knights-who-say-ni @terryjreedy
0