Honor PLATLIBDIR during install #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python builds with an expectation that lib-dynload exists in $(PLATLIBDIR)/python3.9/lib-dynload. platlibdir defaults to lib. During the install process, libdynload is copied to $(BINLIBDEST)/lib-dynload, which is based off of LIBDIR rather than PLATLIBDIR. This succeeds as long as either PLATLIBDIR is specified to match LIBDIR, or LIBDIR is also lib (common)
ucodery
pushed a commit
that referenced
this pull request
Apr 8, 2021
* bpo-40791: Make compare_digest more constant-time. The existing volatile `left`/`right` pointers guarantee that the reads will all occur, but does not guarantee that they will be _used_. So a compiler can still short-circuit the loop, saving e.g. the overhead of doing the xors and especially the overhead of the data dependency between `result` and the reads. That would change performance depending on where the first unequal byte occurs. This change removes that optimization. (This is change #1 from https://bugs.python.org/issue40791 .)
ucodery
pushed a commit
that referenced
this pull request
Apr 14, 2022
) Fix test_gdb.test_pycfunction() for Python built with clang -Og. Tolerate inlined functions in the gdb traceback. When _testcapimodule.c is built by clang -Og, _null_to_none() is inlined in meth_varargs() and so gdb returns _null_to_none() as the frame #1. If it's not inlined, meth_varargs() is the frame #1.
ucodery
pushed a commit
that referenced
this pull request
May 5, 2022
…python#91466) Fix an uninitialized bool in exception print context. `struct exception_print_context.need_close` was uninitialized. Found by oss-fuzz in a test case running under the undefined behavior sanitizer. https://oss-fuzz.com/testcase-detail/6217746058182656 ``` Python/pythonrun.c:1241:28: runtime error: load of value 253, which is not a valid value for type 'bool' #0 0xbf2203 in print_chained cpython3/Python/pythonrun.c:1241:28 #1 0xbea4bb in print_exception_cause_and_context cpython3/Python/pythonrun.c:1320:19 ActiveState#2 0xbea4bb in print_exception_recursive cpython3/Python/pythonrun.c:1470:13 ActiveState#3 0xbe9e39 in _PyErr_Display cpython3/Python/pythonrun.c:1517:9 ``` Pretty obvious what the ommission was upon code inspection.
Repository owner
closed this by deleting the head repository
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python builds with an expectation that lib-dynload exists in $(PLATLIBDIR)/python3.9/lib-dynload.
platlibdir defaults to lib.
During the install process, libdynload is copied to $(BINLIBDEST)/lib-dynload, which is based
off of LIBDIR rather than PLATLIBDIR.
This succeeds as long as either PLATLIBDIR is specified to match LIBDIR, or LIBDIR is also lib (common)