Handle all of java.net exceptions#66
Merged
kishorenc merged 6 commits intotypesense:masterfrom Sep 24, 2024
Merged
Conversation
- Refactor existing test suite for `ApiCall` class, accessing the `nodeIndex` static variable, to avoid flaky tests - Add new test cases ensuring proper handling of all `java.net` exceptions
1 task
kishorenc
approved these changes
Sep 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
On #64, it's mentioned that
java.net.ConnectExceptionis not handled properly by themake_requestmethod onApiCall.To future-proof any more
java.netexceptions being thrown and not handled properly by the method, this PR introducesa check that identifies if the exception thrown has a base class of
java.net, in order to handle every possible case.PR Checklist