8000 fix: add folder filter in server capabilities for `willRename` by luckasRanarison · Pull Request #814 · typescript-language-server/typescript-language-server · GitHub
[go: up one dir, main page]

Skip to content

fix: add folder filter in server capabilities for willRename #814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 17, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion src/lsp-server.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2385,12 +2385,14 @@ describe('completions without client snippet support', () => {
});

describe('fileOperations', () => {
it('willRenameFiles', async () => {
it('willRenameFiles - rename file', async () => {
// TODO: This test depends on ensureConfigurationForDocument being executed first (even for a different file).
const edit = await server.willRenameFiles({
files: [{ oldUri: uri('module1.ts'), newUri: uri('new_module1_name.ts') }],
});
expect(edit.changes).toBeDefined();
expect(Object.keys(edit.changes!)).toHaveLength(1);
// module2 imports from renamed file
expect(edit.changes![uri('module2.ts')]).toEqual([
{
range: {
Expand All @@ -2401,6 +2403,25 @@ describe('fileOperations', () => {
},
]);
});

it('willRenameFiles - rename directory', a 8000 sync () => {
// TODO: This test depends on ensureConfigurationForDocument being executed (even for a different file).
const edit = await server.willRenameFiles({
files: [{ oldUri: uri('rename1'), newUri: uri('rename2') }],
});
expect(edit.changes).toBeDefined();
expect(Object.keys(edit.changes!)).toHaveLength(1);
// module3 imports from renamed directory
expect(edit.changes![uri('module3.ts')]).toEqual([
{
range: {
start:{ line: 0, character: 31 },
end: { line: 0, character: 44 },
},
newText:'./rename2/var',
},
]);
});
});

describe('linked editing', () => {
Expand Down
20 changes: 16 additions & 4 deletions src/lsp-server.ts
Original file line number Diff line number Diff line change
Expand Up @@ -269,10 +269,22 @@ export class LspServer {
workspace: {
fileOperations: {
willRename: {
filters: [{
scheme: 'file',
pattern: { glob: '**/*.{ts,js,jsx,tsx,mjs,mts,cjs,cts}', matches: 'file' },
}],
filters: [
{
scheme: 'file',
pattern: {
glob: '**/*.{ts,js,jsx,tsx,mjs,mts,cjs,cts}',
matches: 'file',
},
},
{
scheme: 'file',
pattern: {
glob: '**',
matches: 'folder',
},
},
],
},
},
},
Expand Down
3 changes: 3 additions & 0 deletions test-data/module3.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
import { fileInRenamed } from './rename1/var';

export { fileInRenamed };
1 change: 1 addition & 0 deletions test-data/rename1/var.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export const fileInRenamed = true;
0