8000 chore: enable `unicorn/prefer-structured-clone` by abrahamguo · Pull Request #9911 · typescript-eslint/typescript-eslint · GitHub
[go: up one dir, main page]
Skip to content

chore: enable unicorn/prefer-structured-clone #9911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 3, 2024
Merged

chore: enable unicorn/prefer-structured-clone #9911

merged 3 commits into from
Sep 3, 2024

Conversation

abrahamguo
Copy link
Contributor

PR Checklist

Overview

Enable unicorn/prefer-structured-clone (docs).

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @abrahamguo!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link
netlify bot commented Sep 2, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 86d8b2b
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/66d663d285845c0008025621
😎 Deploy Preview https://deploy-preview-9911--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 99 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link
nx-cloud bot commented Sep 2, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 86d8b2b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@abrahamguo abrahamguo marked this pull request as draft September 2, 2024 22:53
bradzacher
bradzacher previously approved these changes Sep 2, 2024
View reviewed changes
@abrahamguo abrahamguo marked this pull request as ready for review September 3, 2024 01:18
@abrahamguo
Copy link
Contributor Author

CI failure was because toStrictEqual has an issue with structuredClone because of the constructor property on objects, whereas JSON.parse(JSON.stringify()) does not suffer from the same issue.

I see no problem with changing to use toEqual here, but open to feedback.

@codecov Codecov
Copy link
codecov bot commented Sep 3, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.12%. Comparing base (5d9f49c) to head (86d8b2b).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #9911   +/-   ##
=======================================
  Coverage   88.12%   88.12%           
=======================================
  Files         406      406           
  Lines       13951    13951           
  Branches     4076     4076           
=======================================
  Hits        12294    12294           
  Misses       1344     1344           
  Partials      313      313
Flag Coverage Δ
unittest 88.12% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/utils/src/eslint-utils/applyDefault.ts 100.00% <100.00%> (ø)

@bradzacher bradzacher merged commit 6f24fe6 into typescript-eslint:main Sep 3, 2024
62 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abrahamguo @bradzacher
0