chore: enable unicorn/no-lonely-if #9830
Conversation
|
Thanks for the PR, @abrahamguo! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 20c1f7b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
|
Tests failed due to CI flake. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9830 +/- ##
==========================================
- Coverage 88.01% 88.01% -0.01%
==========================================
Files 406 406
Lines 13879 13873 -6
Branches 4055 4049 -6
==========================================
- Hits 12216 12210 -6
Misses 1354 1354
Partials 309 309
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
I'm surprised how many existing violations we had
I sometimes purposely nested ifs cos I think this:
if (
(ref.identifier.parent.type ===
AST_NODE_TYPES.ExportSpecifier ||
ref.identifier.parent.type ===
AST_NODE_TYPES.ExportDefaultDeclaration ||
ref.identifier.parent.type ===
AST_NODE_TYPES.TSExportAssignment) &&
ref.isValueReference &&
ref.isTypeReference
) {
return node.importKind === 'type';
}is less clear than this:
if (
ref.identifier.parent.type === AST_NODE_TYPES.ExportSpecifier ||
ref.identifier.parent.type ===
AST_NODE_TYPES.ExportDefaultDeclaration ||
ref.identifier.parent.type === AST_NODE_TYPES.TSExportAssignment
) {
if (ref.isValueReference && ref.isTypeReference) {
return node.importKind === 'type';
}
}But I'm not going to block this on that personal preference.
Also when reviewing it's not usually worth the review round-trip to ask someone to de-nest them unless there are other changes. So they sneak in -- cos ultimately it's just a style thing so no need to go abck and manually fix things later.
PR Checklist
eslint-plugin-unicornrules internally #9623Overview
Since we already enable
no-lonely-ifin #9547 (which handleselse { if (a) }=>else if (a) {}, this is the next logic step to enableunicorn/no-lonely-if(docs), which handlesif (a) { if (b) {} }=>if (a && b) {}.Tests failed due to CI flake.