8000 chore: enable `unicorn/prefer-node-protocol` by abrahamguo · Pull Request #9742 · typescript-eslint/typescript-eslint · GitHub
[go: up one dir, main page]
Skip to content
8000

chore: enable unicorn/prefer-node-protocol #9742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 15, 2024
Merged

chore: enable unicorn/prefer-node-protocol #9742

merged 4 commits into from
Aug 15, 2024

Conversation

abrahamguo
Copy link
Contributor

PR Checklist

Overview

Enable unicorn/prefer-node-protocol (docs). 100% autofixable.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @abrahamguo!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link
netlify bot commented Aug 7, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 525e1ac
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/66bd058fd6211f0008e0230d
😎 Deploy Preview https://deploy-preview-9742--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 89 (🔴 down 11 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link
nx-cloud bot commented Aug 7, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 525e1ac. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

Josh-Cena
Josh-Cena previously approved these changes Aug 7, 2024
View reviewed changes
kirkwaiblinger
kirkwaiblinger previously approved these changes Aug 7, 2024
View reviewed changes
JoshuaKGoldberg
JoshuaKGoldberg previously approved these changes Aug 7, 2024
View reviewed changes
Copy link
Member
@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YES

@abrahamguo
Copy link
Contributor Author

Since CI is now green on main, looks like I'll need to look into these scary-looking CI failures. 👻

Let me know if anyone has any ideas off the top of their head. At a glance, I do not see how the CI failures could be related to this change, so I'll have to do a deep dive when I get a chance.

@JoshuaKGoldberg JoshuaKGoldberg dismissed stale reviews from Josh-Cena, kirkwaiblinger, and themself via 525e1ac August 14, 2024 19:29
@kirkwaiblinger kirkwaiblinger added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Aug 15, 2024
@JoshuaKGoldberg JoshuaKGoldberg merged commit 382e87b into typescript-eslint:main Aug 15, 2024
28 of 59 checks passed
@abrahamguo abrahamguo deleted the prefer-node-protocol branch August 19, 2024 11:52
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kirkwaiblinger kirkwaiblinger kirkwaiblinger approved these changes

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg left review comments

@Josh-Cena Josh-Cena Josh-Cena left review comments

Assignees
No one assigned
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abrahamguo @JoshuaKGoldberg @kirkwaiblinger @Josh-Cena
0