8000 chore: enable unicorn/no-useless-spread by abrahamguo · Pull Request #9687 · typescript-eslint/typescript-eslint · GitHub
[go: up one dir, main page]
Skip to content

chore: enable unicorn/no-useless-spread #9687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 5, 2024
Merged

chore: enable unicorn/no-useless-spread #9687

merged 2 commits into from
Aug 5, 2024

Conversation

abrahamguo
Copy link
Contributor

PR Checklist

Overview

Enable unicorn/no-useless-spread (docs).

@abrahamguo
no-useless-spread
< 8000 batch-deferred-content class="d-inline-block" data-url="/commits/badges">
507e7d9
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @abrahamguo!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link
netlify bot commented Jul 31, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 5339d19
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/66b0bafc52b5850008162a2a
😎 Deploy Preview https://deploy-preview-9687--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 99 (🟢 up 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link
nx-cloud bot commented Jul 31, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 5339d19. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@abrahamguo
Copy link
Contributor Author

Ready for review; lint failure seems to be CI flake.

JoshuaKGoldberg
JoshuaKGoldberg previously approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member
@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆒

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Jul 31, 2024
Josh-Cena
Josh-Cena previously approved these changes Aug 1, 2024
View reviewed changes
kirkwaiblinger
kirkwaiblinger previously approved these changes Aug 1, 2024
View reviewed changes
@codecov Codecov
Copy link
codecov bot commented Aug 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.07%. Comparing base (aba6e37) to head (5339d19).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #9687   +/-   ##
=======================================
  Coverage   88.07%   88.07%           
=======================================
  Files         402      402           
  Lines       13691    13691           
  Branches     3982     3982           
=======================================
  Hits        12058    12058           
  Misses       1324     1324           
  Partials      309      309
Flag Coverage Δ
unittest 88.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...plugin/src/rules/naming-convention-utils/schema.ts 100.00% <ø> (ø)

@Josh-Cena Josh-Cena merged commit fbcfaba into typescript-eslint:main Aug 5, 2024
58 of 60 checks passed
@github-actions 7E1D github-actions bot locked as resolved and limited conversation to collaborators Aug 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Josh-Cena Josh-Cena Josh-Cena approved these changes

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg left review comments

@kirkwaiblinger kirkwaiblinger kirkwaiblinger left review comments

Assignees
No one assigned
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abrahamguo @JoshuaKGoldberg @kirkwaiblinger @Josh-Cena
0