8000 fix(utils): context.parserPath may be undefined by JoshuaKGoldberg · Pull Request #9486 · typescript-eslint/typescript-eslint · GitHub
[go: up one dir, main page]
Skip to content

fix(utils): context.parserPath may be undefined #9486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 6, 2024
Merged

fix(utils): context.parserPath may be undefined #9486

merged 2 commits into from
Jul 6, 2024

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

First switches parserPath to string | undefined, then adds in handling to try to use context.languageOptions.parser.meta.name if it exists.

💖

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link
netlify bot commented Jul 3, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 674cb58
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6685b7294fe0da000817d988
😎 Deploy Preview https://deploy-preview-9486--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 95 (🟢 up 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@JoshuaKGoldberg JoshuaKGoldberg requested a review from a team July 3, 2024 18:47
@nx-cloud Nx Cloud
Copy link
nx-cloud bot commented Jul 3, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 674cb58. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 1 target

Sent with 💌 from NxCloud.
8000

@codecov Codecov
Copy link
codecov bot commented Jul 3, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.26%. Comparing base (2865d31) to head (674cb58).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #9486   +/-   ##
=======================================
  Coverage   88.26%   88.26%           
=======================================
  Files         417      417           
  Lines       14413    14414    +1     
  Branches     4208     4211    +3     
=======================================
+ Hits        12721    12722    +1     
  Misses       1372     1372           
  Partials      320      320
Flag Coverage Δ
unittest 88.26% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ckages/utils/src/eslint-utils/getParserServices.ts 94.11% <100.00%> (+0.36%) ⬆️
.../utils/src/eslint-utils/parserSeemsToBeTSESLint.ts 100.00% <100.00%> (ø)

bradzacher
bradzacher previously approved these changes Jul 3, 2024
View reviewed changes
@JoshuaKGoldberg @bradzacher
Update packages/utils/src/eslint-utils/getParserServices.ts
674cb58 8ACD 
Co-authored-by: Brad Zacher <brad.zacher@gmail.com>
@JoshuaKGoldberg JoshuaKGoldberg merged commit 103de6e into typescript-eslint:main Jul 6, 2024
62 of 63 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: RuleContext.parserPath should be string | undefined, not string
2 participants
@JoshuaKGoldberg @bradzacher
0