10000 feat(eslint-plugin): add support for nested namespaces to unsafe-member-access by JSanchezIO · Pull Request #9478 · typescript-eslint/typescript-eslint · GitHub
[go: up one dir, main page]
Skip to content

feat(eslint-plugin): add support for nested namespaces to unsafe-member-access #9478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 6, 2024
Merged

feat(eslint-plugin): add support for nested namespaces to unsafe-member-access #9478

merged 4 commits into from
Jul 6, 2024

Conversation

JSanchezIO
Copy link
Contributor

PR Checklist

Overview

The rule no-unsafe-member-access was originally targeted all MemberExpression nodes. Eventually, it was updated, #2753, to ignore a MemberExpression if its parent was either TSClassImplements or TSInterfaceHeritage. However, this only accounts for one-level of nesting in namespaces. This change accounts for any level of nesting by ignoring the MemberExpression if the root node is TSClassImplements or TSInterfaceHeritage.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JSanchezIO!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link
netlify bot commented Jul 2, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 118a333
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6688eea5f9bcf200081e898b
😎 Deploy Preview https://deploy-preview-9478--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 99 (🟢 up 5 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link
nx-cloud bot commented Jul 2, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 118a333. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 31 targets

Sent with 💌 from NxCloud.

auvred
auvred previously approved these changes Jul 4, 2024
View reviewed changes
Copy link
Member
@auvred auvred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 👍

@auvred auvred added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Jul 4, 2024
JoshuaKGoldberg
JoshuaKGoldberg previously approved these changes Jul 5, 2024
View reviewed changes
Copy link
Member
@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@JSanchezIO JSanchezIO dismissed stale reviews from JoshuaKGoldberg and auvred via abe2c5e July 6, 2024 07:13
JSanchezIO and others added 2 commits July 6, 2024 00:13
@JSanchezIO @JoshuaKGoldberg
docs(eslint-plugin): adjust selector explanation
abe2c5e 
Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
@JSanchezIO
Merge branch 'main' into main
118a333
@codecov Codecov
Copy link
codecov bot commented Jul 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.33%. Comparing base (ceb9b88) to head (118a333).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #9478   +/-   ##
=======================================
  Coverage   88.33%   88.33%           
=======================================
  Files         418      418           
  Lines       14535    14535           
  Branches     4248     4248           
=======================================
  Hits        12840    12840           
  Misses       1374     1374           
  Partials      321      321
Flag Coverage Δ
unittest 88.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...eslint-plugin/src/rules/no-unsafe-member-access.ts 100.00% <ø> (ø)

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Jul 6, 2024
View reviewed changes
Copy link
Member
@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 thanks!

@JoshuaKGoldberg JoshuaKGoldberg merged commit d685948 into typescript-eslint:main Jul 6, 2024
65 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

@auvred auvred Awaiting requested review from auvred

Assignees
No one assigned
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[no-unsafe-member-access] Not allowing "interface X extends" for a type in a nested namespace
3 participants
@JSanchezIO @JoshuaKGoldberg @auvred
0