8000 docs(eslint-plugin): [sort-type-constituents] deprecate the rule by JoshuaKGoldberg · Pull Request #9253 · typescript-eslint/typescript-eslint · GitHub
[go: up one dir, main page]
Skip to content

docs(eslint-plugin): [sort-type-constituents] deprecate the rule #9253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 5, 2024
Merged

docs(eslint-plugin): [sort-type-constituents] deprecate the rule #9253

merged 3 commits into from
Jun 5, 2024

Conversation

JoshuaKGoldberg
Copy link
Member
@JoshuaKGoldberg JoshuaKGoldberg commented Jun 4, 2024 •
edited
Loading

PR Checklist

Overview

Marks the rule as meta.deprecated. This is purely a documentation change, as the rule already isn't in any stable shared configs.

Note that we have no plans to remove the rule in v8. Per #8915, there are a couple of repositories that still use it. IMO it'd be nice to give them (and any closed-source repos we don't know about) a bit more time before deleting the rule.

💖

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link
netlify bot commented Jun 4, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit f6a61d3
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/665f1cfdad568b00088a579f
😎 Deploy Preview https://deploy-preview-9253--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (🔴 down 3 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (🔴 down 8 from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Jun 4, 2024
Closed
2 tasks
@nx-cloud Nx Cloud
Copy link
nx-cloud bot commented Jun 4, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f6a61d3. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 31 targets

Sent with 💌 from NxCloud.

@JoshuaKGoldberg JoshuaKGoldberg requested a review from a team June 4, 2024 13:43
JoshuaKGoldberg
JoshuaKGoldberg commented Jun 4, 2024
View reviewed changes
kirkwaiblinger
kirkwaiblinger approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member
@kirkwaiblinger kirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

knife

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Jun 4, 2024
@JoshuaKGoldberg JoshuaKGoldberg merged commit c6e9719 into typescript-eslint:main Jun 5, 2024
65 of 66 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kirkwaiblinger kirkwaiblinger kirkwaiblinger approved these changes

Assignees
53B7 No one assigned
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: Deprecate sort-type-constituents in favor of eslint-plugin-perfectionist
2 participants
@JoshuaKGoldberg @kirkwaiblinger
0