8000 docs: make absolute links relative by FloEdelmann · Pull Request #9107 · typescript-eslint/typescript-eslint · GitHub
[go: up one dir, main page]

Skip to content

docs: make absolute links relative #9107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2024
Merged

docs: make absolute links relative #9107

merged 1 commit into from
May 16, 2024

Conversation

FloEdelmann
Copy link
Contributor
@FloEdelmann FloEdelmann commented May 16, 2024

PR Checklist

Overview

Absolute links open in a new tab. Since these are links to other docs pages, these should be relative links instead which open in the same tab.

I've checked that these are the only absolute links to typescript-eslint.io.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @FloEdelmann!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link
netlify bot commented May 16, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 1313bb9
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/66462616c1970b000990c784
😎 Deploy Preview https://deploy-preview-9107--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 97 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
nx-cloud bot commented May 16, 2024

Copy link
codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.41%. Comparing base (1a18eba) to head (1313bb9).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9107      +/-   ##
==========================================
- Coverage   88.05%   87.41%   -0.64%     
==========================================
  Files         410      260     -150     
  Lines       14195    12617    -1578     
  Branches     4140     3942     -198     
==========================================
- Hits        12499    11029    -1470     
+ Misses       1391     1313      -78     
+ Partials      305      275      -30     
Flag Coverage Δ
unittest 87.41% <ø> (-0.64%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 150 files with indirect coverage changes

Copy link
Member
@kirkwaiblinger kirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me!

Thanks @FloEdelmann !

@kirkwaiblinger kirkwaiblinger merged commit a2721e3 into typescript-eslint:main May 16, 2024
65 of 66 checks passed
@FloEdelmann FloEdelmann deleted the patch-1 branch May 16, 2024 15:53
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0