fix(typescript-estree): don't add in-project files to defaultProjectMatchedFiles #9097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR Checklist
Overview
Only add path to
defaultProjectMatchedFilesifopened.configFileNameis falsy.The fix itself is pretty trivial and existing tests still pass, but I might need some help with adding a new testcase. I tried adapting the existing testcase at
typescript-eslint/packages/typescript-estree/tests/lib/useProgramFromProjectService.test.ts
Line 122 in 77fc366
fix(typescript-estree): don't add in-project files to defaultProjectM…be4b2f3Thanks for the PR, @ehoogeveen-medweb!
typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.
The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.
Thanks again!
🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.
Uh oh!
There was an error while loading. Please reload this page.
✅ Deploy Preview for typescript-eslint ready!
Toggle QR Code...
Use your smartphone camera to open QR code link.
Lighthouse
Performance: 99 (🟢 up 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports
To edit notification comments on pull requests, go to your Netlify site configuration.
Uh oh!
There was an error while loading. Please reload this page.
☁️ Nx Cloud Report
CI is running/has finished running commands for commit 449d30e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.
📂 See all runs for this CI Pipeline Execution
✅ Successfully ran 31 targets
nx test eslint-plugin --coverage=falsenx test eslint-pluginnx test typescript-estree --coverage=falsenx test visitor-keys --coverage=falsenx run types:buildnx test scope-manager --coverage=falsenx test type-utils --coverage=falsenx test typescript-eslint --coverage=falsenx run repo-tools:postinstall-scriptnx test rule-schema-to-typescript-types --coverage=falsenx test utils --coverage=falsenx test repo-tools --coverage=falsenx test parser --coverage=falsenx test eslint-plugin-internal --coverage=falsenx run-many --target=lint --parallel --exclude eslint-pluginnx test visitor-keysnx test utilsnx test ast-spec --coverage=falsenx run-many --target=build --parallel --exclude=website --exclude=website-eslintnx test typescript-estreenx test type-utilsnx test scope-managernx test ast-specnx test typescript-eslintnx test rule-schema-to-typescript-typesnx test eslint-plugin-internalnx test parsernx test repo-toolsnx run integration-tests:testnx run-many --target=typecheck --parallelnx run repo-tools:generate-configsSent with 💌 from NxCloud.
Linting is clean locally. From the log, it looks like
website-eslint:lintfailed with anAtomicsWaitError, so I doubt it's me 😄Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Source code change looks nice and clean! 🙌
test(typescript-estree): add additional unit test for project service449d30eThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a124d4finto typescript-eslint:mainUh oh!
There was an error while loading. Please reload this page.
@ehoogeveen-medweb @JoshuaKGoldberg Thanks for the PR, review and merge 🙌
I'm trying out the v8 alpha releases, and I didn't see this change in
dist/useProgramFromProjectService.jsin the latest v8 alpha (although the latest v7 alpha does contain the change):@typescript-eslint/typescript-estree@8.0.0-alpha.13@typescript-eslint/typescript-estree@7.9.1-alpha.6Would it be possible to get a v8 alpha version published with this change?
I tried opening a PR to merge
mainintov8(similar to 0d85360), but it gave me an error:We merged the
mainbranch intov8and now8.0.0-alpha.14should include everything. 👍Labels
3 participants