8000 chore: fix v8 branch snapshots for flat-config-types by JoshuaKGoldberg · Pull Request #9029 · typescript-eslint/typescript-eslint · GitHub
[go: up one dir, main page]
Skip to content

chore: fix v8 branch snapshots for flat-config-types #9029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 29, 2024
Merged

chore: fix v8 branch snapshots for flat-config-types #9029

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e7092a0
chore: fix v8 branch snapshots for flat-config-types
JoshuaKGoldberg Apr 29, 2024
ce2a7ce
Check in the rest of them too
JoshuaKGoldberg Apr 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ jobs:
- name: Build
uses: ./.github/actions/prepare-build

- name: Run integrations tests
- name: Run integration tests
run: yarn test-integration
env:
CI: true
Expand Down
2 changes: 1 addition & 1 deletion packages/integration-tests/tests/__snapshots__/flat-config-types.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ exports[`flat-config-types eslint should work successfully 1`] = `
"line": 38,
"message": "'_otherCases' is defined but never used.",
"messageId": "unusedVar",
"nodeType": "Identifier",
"nodeType": null,
Copy link
Member Author
@JoshuaKGoldberg JoshuaKGoldberg Apr 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ... don't know why this is happening. None of the recent no-unused-vars ESLint PRs seem relevant. But the actual rule seems to work internally. 🤷

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8127873 / #8640

This commit changed the context.report from { node, ... } to { loc, ... }
Hence the nodeType is no longer visible in the output as the rule is not reporting against the node.

"ruleId": "@typescript-eslint/no-unused-vars",
"severity": 2,
},
Expand Down
4 changes: 2 additions & 2 deletions ...s/integration-tests/tests/__snapshots__/recommended-does-not-require-program.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,12 @@ exports[`recommended-does-not-require-program eslint should work successfully 1`
"messages": [
{
"column": 7,
"endColumn": 19,
"endColumn": 10,
"endLine": 1,
"line": 1,
"message": "'foo' is assigned a value but never used.",
"messageId": "unusedVar",
"nodeType": "Identifier",
"nodeType": null,
"ruleId": "@typescript-eslint/no-unused-vars",
"severity": 2,
},
Expand Down
6 changes: 3 additions & 3 deletions packages/integration-tests/tests/__snapshots__/vue-sfc.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ exports[`vue-sfc eslint should work successfully 1`] = `
"messages": [
{
"fatal": true,
"message": "Parsing error: Cannot read file '/usr/linked/tsconfig.json'.",
"message": "Parsing error: error TS5012: Cannot read file '/usr/linked/tsconfig.json': ENOENT: no such file or directory, open '/usr/linked/tsconfig.json'.",
"nodeType": null,
"ruleId": null,
"severity": 2,
Expand Down Expand Up @@ -75,7 +75,7 @@ export default Vue.extend({
"messages": [
{
"fatal": true,
"message": "Parsing error: Cannot read file '/usr/linked/tsconfig.json'.",
"message": "Parsing error: error TS5012: Cannot read file '/usr/linked/tsconfig.json': ENOENT: no such file or directory, open '/usr/linked/tsconfig.json'.",
"nodeType": null,
"ruleId": null,
"severity": 2,
Expand Down Expand Up @@ -115,7 +115,7 @@ export default class Utility {
"messages": [
{
"fatal": true,
"message": "Parsing error: Cannot read file '/usr/linked/tsconfig.json'.",
"message": "Parsing error: error TS5012: Cannot read file '/usr/linked/tsconfig.json': ENOENT: no such file or directory, open '/usr/linked/tsconfig.json'.",
"nodeType": null,
"ruleId": null,
"severity": 2,
Expand Down
0