8000 feat(website): playground Visual Editor search makes case-insensitive by developer-bandi · Pull Request #8767 · typescript-eslint/typescript-eslint · GitHub
[go: up one dir, main page]
Skip to content

feat(website): playground Visual Editor search makes case-insensitive #8767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 25, 2024
Merged

feat(website): playground Visual Editor search makes case-insensitive #8767

merged 1 commit into from
Mar 25, 2024

Conversation

developer-bandi
Copy link
Contributor

PR Checklist

Overview

playground Visual Editor search makes case-insensitive

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @developer-bandi!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link
netlify bot commented Mar 25, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 362fcab
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6601799d36a4900008d66ac6
😎 Deploy Preview https://deploy-preview-8767--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 98 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link
nx-cloud bot commented Mar 25, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 362fcab. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 31 targets

Sent with 💌 from NxCloud.

@codecov Codecov
Copy link
codecov bot commented Mar 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.33%. Comparing base (4132374) to head (362fcab).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8767      +/-   ##
==========================================
- Coverage   87.38%   87.33%   -0.06%     
==========================================
  Files         254      254              
  Lines       12489    12467      -22     
  Branches     3919     3912       -7     
==========================================
- Hits        10914    10888      -26     
  Misses       1304     1304              
- Partials      271      275       +4
Flag Coverage Δ
unittest 87.33% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member
@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks! 🥇

@JoshuaKGoldberg JoshuaKGoldberg merged commit 506a7bf into typescript-eslint:main Mar 25, 2024
peanutenthusiast pushed a commit to peanutenthusiast/typescript-eslint that referenced this pull request Mar 27, 2024
@developer-bandi @peanutenthusiast
feat(website): playground Visual Editor search makes case-insensitive (…
b055ce0 
…typescript-eslint#8767)

feat: website visualEditor makes case-sensitive
yeonjuan pushed a commit to yeonjuan/typescript-eslint that referenced this pull request Mar 31, 2024
@developer-bandi @yeonjuan
feat(website): playground Visual Editor search makes case-insensitive (…
574f9dd 
…typescript-eslint#8767)

feat: website visualEditor makes case-sensitive
@bradzacher
Copy link
Member

@JoshuaKGoldberg don't forget to update the PR title for website PRs before you merge them!
This caused us to do a minor release instead of a patch release.

@JoshuaKGoldberg
Copy link
Member

Blagh.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: Playground Visual Editor search is case-sensitive
3 participants
@developer-bandi @bradzacher @JoshuaKGoldberg
0