8000 feat(eslint-plugin-internal): add internal lint rule no-relative-paths-to-internal-packages by kirkwaiblinger · Pull Request #8596 · typescript-eslint/typescript-eslint · GitHub
[go: up one dir, main page]
Skip to content

feat(eslint-plugin-internal): add internal lint rule no-relative-paths-to-internal-packages #8596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 18, 2024
Merged

feat(eslint-plugin-internal): add internal lint rule no-relative-paths-to-internal-packages #8596

merged 1 commit into from
Mar 18, 2024

Conversation

kirkwaiblinger
Copy link
Member

PR Checklist

Overview

Adds internal lint rule to look for flag relative imports that import code from other packages.

Found no existing violations! :)

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @kirkwaiblinger!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link
netlify bot commented Mar 5, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit e73995d
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/65e67828023cd5000877d3e0
😎 Deploy Preview https://deploy-preview-8596--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 99 (🟢 up 9 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@kirkwaiblinger kirkwaiblinger changed the title Add internal lint rule no-relative-paths-to-internal-packages fix(eslint-plugin-internal): Add internal lint rule no-relative-paths-to-internal-packages Mar 5, 2024
@kirkwaiblinger kirkwaiblinger changed the title fix(eslint-plugin-internal): Add internal lint rule no-relative-paths-to-internal-packages fix(eslint-plugin-internal): add internal lint rule no-relative-paths-to-internal-packages Mar 5, 2024
@nx-cloud Nx Cloud
Copy link
nx-cloud bot commented Mar 5, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e73995d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

🟥 Failed Commands
nx run integration-tests:test
✅ Successfully ran 30 targets

Sent with 💌 from NxCloud.

kirkwaiblinger
kirkwaiblinger commented Mar 5, 2024
View reviewed changes
packages/eslint-plugin-internal/src/rules/no-relative-paths-to-internal-packages.ts

import { createRule } from '../util';

export const REPO_ROOT = path.resolve(__dirname, '../../../..');
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tried to import this from /packages/repo-tools/src/paths.mts but ts was upset about some module stuff that I didn't really understand.

@kirkwaiblinger kirkwaiblinger force-pushed the no-internal-relative-paths branch from 088d69b to e73995d Compare March 5, 2024 01:40
@codecov Codecov
Copy link
codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.14%. Comparing base (6954a4a) to head (e73995d).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8596      +/-   ##
==========================================
+ Coverage   87.12%   87.14%   +0.01%     
==========================================
  Files         251      252       +1     
  Lines       12268    12287      +19     
  Branches     3868     3871       +3     
==========================================
+ Hits        10689    10708      +19     
  Misses       1307     1307              
  Partials      272      272
Flag Coverage Δ
unittest 87.14% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...rc/rules/no-relative-paths-to-internal-packages.ts 100.00% <100.00%> (ø)

@kirkwaiblinger
Copy link
Member Author

Not sure about the CI failure, but it appears to be failing on other recent PRs as well

@kirkwaiblinger kirkwaiblinger marked this pull request as ready for review March 5, 2024 01:55
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Mar 18, 2024
View reviewed changes
Copy link
Member
@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Michael Scott happily saying "I LOVE IT! I LOVE IT!"

@JoshuaKGoldberg
Copy link
Member

Yeah, the integration tests are unrelated. This is great - thanks!

@JoshuaKGoldberg JoshuaKGoldberg changed the title fix(eslint-plugin-internal): add internal lint rule no-relative-paths-to-internal-packages feat(eslint-plugin-internal): add internal lint rule no-relative-paths-to-internal-packages Mar 18, 2024
@JoshuaKGoldberg JoshuaKGoldberg merged commit 8b45691 into typescript-eslint:main Mar 18, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 26, 2024
@kirkwaiblinger kirkwaiblinger deleted the no-internal-relative-paths branch August 28, 2024 05:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repo: Internal linter rule for absolute imports from eslint packages
2 participants
@kirkwaiblinger @JoshuaKGoldberg
0