feat(eslint-plugin-internal): add internal lint rule no-relative-paths-to-internal-packages #8596
Conversation
|
Thanks for the PR, @kirkwaiblinger! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
|
||
| import { createRule } from '../util'; | ||
|
|
||
| export const REPO_ROOT = path.resolve(__dirname, '../../../..'); |
There was a problem hiding this comment.
tried to import this from /packages/repo-tools/src/paths.mts but ts was upset about some module stuff that I didn't really understand.
088d69b to
e73995d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8596 +/- ##
==========================================
+ Coverage 87.12% 87.14% +0.01%
==========================================
Files 251 252 +1
Lines 12268 12287 +19
Branches 3868 3871 +3
==========================================
+ Hits 10689 10708 +19
Misses 1307 1307
Partials 272 272
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Not sure about the CI failure, but it appears to be failing on other recent PRs as well |
|
Yeah, the integration tests are unrelated. This is great - thanks! |
PR Checklist
Overview
Adds internal lint rule to look for flag relative imports that import code from other packages.
Found no existing violations! :)