8000
We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
There was an error while loading. Please reload this page.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds internal lint rule to look for flag relative imports that import code from other packages.
Found no existing violations! :)
Sorry, something went wrong.
Thanks for the PR, @kirkwaiblinger!
typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.
The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.
Thanks again!
🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.
To edit notification comments on pull requests, go to your Netlify site configuration.
CI is running/has finished running commands for commit e73995d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.
📂 See all runs for this CI Pipeline Execution
nx run integration-tests:test
nx test visitor-keys
nx run types:build
nx test typescript-eslint
nx test typescript-estree
nx test utils
nx run repo-tools:postinstall-script
nx test type-utils
nx test scope-manager
nx test eslint-plugin-internal
nx test rule-schema-to-typescript-types
nx run-many --target=build --parallel --exclude=website --exclude=website-eslint
nx test repo-tools
nx test parser
nx test eslint-plugin
nx test ast-spec
nx run-many --target=lint --parallel --exclude eslint-plugin
nx run-many --target=typecheck --parallel
nx test eslint-plugin-internal --coverage=false
nx test rule-schema-to-typescript-types --coverage=false
nx test scope-manager --coverage=false
nx test repo-tools --coverage=false
nx test type-utils --coverage=false
nx test eslint-plugin --coverage=false
nx test parser --coverage=false
nx test ast-spec --coverage=false
nx test typescript-eslint --coverage=false
nx test typescript-estree --coverage=false
nx test utils --coverage=false
nx test visitor-keys --coverage=false
nx run repo-tools:generate-configs
Sent with 💌 from NxCloud.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
tried to import this from /packages/repo-tools/src/paths.mts but ts was upset about some module stuff that I didn't really understand.
/packages/repo-tools/src/paths.mts
Add internal lint rule no-relative-paths-to-internal-packages
e73995d
088d69b
All modified and coverable lines are covered by tests ✅
Project coverage is 87.14%. Comparing base (6954a4a) to head (e73995d). Report is 1 commits behind head on main.
6954a4a
@@ Coverage Diff @@ ## main #8596 +/- ## ========================================== + Coverage 87.12% 87.14% +0.01% ========================================== Files 251 252 +1 Lines 12268 12287 +19 Branches 3868 3871 +3 ========================================== + Hits 10689 10708 +19 Misses 1307 1307 Partials 272 272
87.14% <100.00%> (+0.01%)
Flags with carried forward coverage won't be shown. Click here to find out more.
100.00% <100.00%> (ø)
Not sure about the CI failure, but it appears to be failing on other recent PRs as well
Yeah, the integration tests are unrelated. This is great - thanks!
8b45691
JoshuaKGoldberg JoshuaKGoldberg approved these changes
Successfully merging this pull request may close these issues.