fix(eslint-plugin): [explicit-function-return-type] Fix allowExpressions ignoring default exports #831
Conversation
|
Thanks for the PR, @Svish! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint |
|
By the way, I don't know if I should also create an issue for this issue? That's what I considered to do to begin with, but since I realized it would be super easy to fix, I decided to just create a PR directly instead. But yeah... not sure what you want for project tracking purposes and such. 🤔 |
|
@bradzacher Cool! About updating the rule doc, I definitely could, but looking at it now, I'm not sure exactly what I should update. What it says there now is already correct.
The check I've added is |
… last PR by removing the parameters which are not relevant to the examples
|
I've added two examples of code that after this change will still be incorrect, even with As a minor cleanup of my own earlier PR, I also simplified the examples for |
The current implementation of
allowExpressionsbelow causes default exports to be allowed/ignored:I really think a default export should be considered as much a declaration/definition as a variable declaration is. Maybe even more so, as it's the main export of a module.
Currently only the last one of these fail when
allowExpressionsis set totrue:So in this PR I've added
AST_NODE_TYPES.ExportDefaultDeclarationto the check (and tests for it), so that both those cases are correctly (in my opinion) rejected as lacking a return type.