8000 fix(ast-spec): add `JSXElement` type to the `JSXAttribute['value']` by auvred · Pull Request #8285 · typescript-eslint/typescript-eslint · GitHub
[go: up one dir, main page]
Skip to content

fix(ast-spec): add JSXElement type to the JSXAttribute['value'] #8285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 3, 2024
Merged

fix(ast-spec): add JSXElement type to the JSXAttribute['value'] #8285

merged 4 commits into from
Feb 3, 2024

Conversation

auvred
Copy link
Member
@auvred auvred commented Jan 21, 2024

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @auvred!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link
netlify bot commented Jan 21, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 0f9b00d
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/65b7ee87ebef210008be7e7f
😎 Deploy Preview https://deploy-preview-8285--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 89 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@auvred auvred mentioned this pull request Jan 21, 2024
Merged
JoshuaKGoldberg
JoshuaKGoldberg requested changes Jan 29, 2024
View reviewed changes
Copy link
Member
@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The functional change looks good to me! Just requesting test coverage.

@JoshuaKGoldberg JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Jan 29, 2024
@github-actions github-actions bot removed the awaiting response Issues waiting for a reply from the OP or another party label Jan 29, 2024
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Feb 3, 2024
View reviewed changes
Copy link
Member
@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 thanks!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 2373a63 into typescript-eslint:main Feb 3, 2024
danvk pushed a commit to danvk/typescript-eslint that referenced this pull request Feb 4, 2024
@auvred @danvk
fix(ast-spec): add JSXElement type to the JSXAttribute['value'] (t…
a0029c0 
…ypescript-eslint#8285)

* fix(ast-spec): add `JSXElement` type to the `JSXAttribute['value']`

* test: add fixtures

* chore: sync snapshots
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: JSXElement type is not listed in .value of JSXAttribute
2 participants
@auvred @JoshuaKGoldberg
0