8000 chore: rename release.ts to release.mts by JoshuaKGoldberg · Pull Request #8204 · typescript-eslint/typescript-eslint · GitHub
[go: up one dir, main page]

Skip to content

chore: rename release.ts to release.mts #8204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 7, 2024

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

ESLint was unhappy with the idea of renaming tools/release/release.ts to release.mts because tsconfig.eslint.json doesn't allow including .mts files.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link
netlify bot commented Jan 6, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit dc7d962
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/659acc43305c4f0008fcfa1d
😎 Deploy Preview https://deploy-preview-8204--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 87 (🔴 down 12 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member
@auvred auvred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fun fact: jest.preset.js listed at the bottom of tsconfig.eslint.json has been deleted in 08ae2c41d, perhaps we can remove it from tsconfig?

bradzacher
bradzacher previously approved these changes Jan 7, 2024
Copy link
Member
@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My point was addressed, but @auvred's seems to be important

8000

Co-authored-by: auvred <61150013+auvred@users.noreply.github.com>
@JoshuaKGoldberg JoshuaKGoldberg merged commit 958feca into typescript-eslint:main Jan 7, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0