-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
fix(eslint-plugin): [no-confusing-void-expression] handle unfixable cases #7674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
22f78d9
to
ef650d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great - nice spot on checking ts.TypeFlags.VoidLike
! This function works perfectly but just has a bit of dead code I think. Requesting changes just on that.
Super thorough tests, too! 👏
packages/eslint-plugin/src/rules/no-confusing-void-expression.ts
Outdated
Show resolved
Hide resolved
ef650d0
to
<
8000
code>eba0284
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Swell, thanks!
PR Checklist
a ? void : T
#6187Overview
This change will prevent autofixes in certain cases. Before the change, it worked like this
I changed to not apply fix to node which can be conditionally void.