8000 docs: explain globals in `RuleTester` for Mocha and Vitest by JoshuaKGoldberg · Pull Request #7606 · typescript-eslint/typescript-eslint · GitHub
[go: up one dir, main page]
Skip to content

docs: explain globals in RuleTester for Mocha and Vitest #7606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 8, 2023
Merged

docs: explain globals in RuleTester for Mocha and Vitest #7606

merged 1 commit into from
Sep 8, 2023

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Copies @bradzacher's comments, which I have tried out locally and found to be exactly enough.

Co-authored-by: @bradzacher

@typescript-eslint
8000 Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link
netlify bot commented Sep 5, 2023 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit eaa676c
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/64f7a5def05edc0009591b23
😎 Deploy Preview https://deploy-preview-7606--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 99 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud
Copy link
nx-cloud bot commented Sep 5, 2023 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit eaa676c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 40 targets

Sent with 💌 from NxCloud.

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review September 5, 2023 22:17
@bradzacher bradzacher added the documentation Documentation ("docs") that needs adding/updating label Sep 8, 2023
@bradzacher bradzacher changed the title docs: explain globals in RuleTester for Mocha and Vitest docs: explain globals in RuleTester for Mocha and Vitest Sep 8, 2023
@bradzacher bradzacher merged commit c15daf9 into typescript-eslint:main Sep 8, 2023
@JoshuaKGoldberg JoshuaKGoldberg deleted the docs-rule-tester-globals branch September 8, 2023 00:25
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
documentation Documentation ("docs") that needs adding/updating
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: document how to setup RuleTester.afterAll
2 participants
@JoshuaKGoldberg @bradzacher
0