8000 docs: add in the pull request file to not comment in closed prs by sfavello · Pull Request #7592 · typescript-eslint/typescript-eslint · GitHub
[go: up one dir, main page]
Skip to content

docs: add in the pull request file to not comment in closed prs #7592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 5, 2023
Merged

docs: add in the pull request file to not comment in closed prs #7592

merged 5 commits into from
Sep 5, 2023

Conversation

sfavello
Copy link
Contributor
@sfavello sfavello commented Sep 2, 2023

PR Checklist

Overview

Added a part in the pull requests page to not comment in PRs that has been closed and instead to file a new issue.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @sfavello!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link
netlify bot commented Sep 2, 2023 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 0f2a6c0
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/64f78a1d4d49850008f4b7aa
😎 Deploy Preview https://deploy-preview-7592--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 90 (🔴 down 9 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@sfavello sfavello marked this pull request as ready for review September 2, 2023 17:28
@nx-cloud
Copy link
nx-cloud bot commented Sep 2, 2023 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 0f2a6c0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 40 targets

Sent with 💌 from NxCloud.

JoshuaKGoldberg
JoshuaKGoldberg previously approved these changes Sep 2, 2023
View reviewed changes
Copy link
Member
@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 thanks!

@JoshuaKGoldberg
Copy link
Member

Oh - looks like a formatting issue in CI? I'm on mobile and can't check deeply at the moment.

@sfavello
Copy link
Contributor Author
sfavello commented Sep 2, 2023

@JoshuaKGoldberg , Sorry about that. There was space after the period. Should be fixed. 👍🏼

JoshuaKGoldberg
JoshuaKGoldberg previously approved these changes Sep 2, 2023
View reviewed changes
Josh-Cena
Josh-Cena requested changes Sep 2, 2023
View reviewed changes
sfavello and others added 2 commits September 2, 2023 14:05
@sfavello @Josh-Cena
update docs/contributing/Pull_Requests.mdx
137fbdf 
Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
@sfavello @Josh-Cena
update docs/contributing/Pull_Requests.mdx
dce68b6 
Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
Josh-Cena
Josh-Cena approved these changes Sep 5, 2023
View reviewed changes
Copy link
Member
@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfavello @Josh-Cena
Update docs/contributing/Pull_Requests.mdx
0f2a6c0 
Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
@codecov
Copy link
codecov bot commented Sep 5, 2023 •
edited
Loading

Codecov Report

Merging #7592 (0f2a6c0) into main (4899b95) will not change coverage.
Report is 9 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #7592   +/-   ##
=======================================
  Coverage   87.23%   87.23%           
=======================================
  Files         387      387           
  Lines       13401    13401           
  Branches     3962     3962           
=======================================
  Hits        11690    11690           
  Misses       1327     1327           
  Partials      384      384
Flag Coverage Δ
unittest 87.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

JoshuaKGoldberg
JoshuaKGoldberg reviewed Sep 5, 2023
View reviewed changes
Copy link
Member
@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@JoshuaKGoldberg JoshuaKGoldberg merged commit 8175224 into typescript-eslint:main Sep 5, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg left review comments

@Josh-Cena Josh-Cena Josh-Cena approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: Ask not to post followup questions on merged PRs
3 participants
@sfavello @JoshuaKGoldberg @Josh-Cena
0