8000 docs(eslint-plugin): update correct code example for sort-type-constituents by DimitarNestorov · Pull Request #7050 · typescript-eslint/typescript-eslint · GitHub
[go: up one dir, main page]
Skip to content

docs(eslint-plugin): update correct code example for sort-type-constituents #7050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2023
Merged

docs(eslint-plugin): update correct code example for sort-type-constituents #7050

merged 1 commit into from
May 28, 2023

Conversation

DimitarNestorov
Copy link
Contributor
@DimitarNestorov DimitarNestorov commented May 22, 2023 •
edited
Loading

PR Checklist

Overview

Noticed that the string literals in the "Correct" example weren't sorted so I ran the example code through the playground and it resulted in the changes in this PR.

Preview: https://deploy-preview-7050--typescript-eslint.netlify.app/rules/sort-type-constituents/#examples

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @DimitarNestorov!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link
netlify bot commented May 22, 2023 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 90b04cc
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/646b9d786887dd00089987d9
😎 Deploy Preview https://deploy-preview-7050--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@DimitarNestorov DimitarNestorov changed the title docs(eslint-plugin): Update correct code example for sort-type-constituents docs(eslint-plugin): update correct code example for sort-type-constituents May 22, 2023
@nx-cloud
Copy link
nx-cloud bot commented May 22, 2023 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 90b04cc. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 25 targets

Sent with 💌 from NxCloud.

JoshuaKGoldberg
JoshuaKGoldberg approved these changes May 28, 2023
View reviewed changes
Copy link
Member
@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 😄 thanks!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 6b8ec6e into typescript-eslint:main May 28, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DimitarNestorov @JoshuaKGoldberg

Footer

© 2025 GitHub, Inc.
0