8000 chore: update to TypeScript 5.0.2 by sosukesuzuki · Pull Request #6662 · typescript-eslint/typescript-eslint · GitHub
[go: up one dir, main page]
Skip to content

chore: update to TypeScript 5.0.2 #6662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 20, 2023
Merged

chore: update to TypeScript 5.0.2 #6662

merged 6 commits into from
Mar 20, 2023

Conversation

sosukesuzuki
Copy link
Contributor

PR Checklist

Overview

TS 5.0 has been released https://devblogs.microsoft.com/typescript/announcing-typescript-5-0/

So we can update typescript to 5.0.2

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @sosukesuzuki!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link
netlify bot commented Mar 17, 2023 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 4b5b737
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6417a794530dcf00082bc494
😎 Deploy Preview https://deploy-preview-6662--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nx-cloud
Copy link
nx-cloud bot commented Mar 17, 2023 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 4b5b737. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 25 targets

Sent with 💌 from NxCloud.

@codecov
Copy link
codecov bot commented Mar 17, 2023 •
edited
Loading

Codecov Report

Merging #6662 (4b5b737) into main (7a7725d) will increase coverage by 2.03%.
The diff coverage is n/a.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6662      +/-   ##
==========================================
+ Coverage   85.16%   87.19%   +2.03%     
==========================================
  Files         383      383              
  Lines       13033    13035       +2     
  Branches     3840     3841       +1     
==========================================
+ Hits        11099    11366     +267     
+ Misses       1572     1303     -269     
- Partials      362      366       +4
Flag Coverage Δ
unittest 87.19% <ø> (+2.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Mar 18, 2023
View reviewed changes
Copy link
Member
@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@JoshuaKGoldberg
Copy link
Member

A note for folks 👍 and 🚀 reacting to this PR: this is just a devDependency change for our repository. It doesn't impact typescript-eslint support for TypeScript v5. That support already landed (#6380). 😄

JoshuaKGoldberg
JoshuaKGoldberg requested changes Mar 19, 2023
View reviewed changes
Copy link
Member
@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like some type checking issues popped up?

@bradzacher bradzacher changed the title feat: update to TypeScript 5.0.2 chore: update to TypeScript 5.0.2 Mar 20, 2023
@bradzacher bradzacher added the dependencies Issue about dependencies of the package label Mar 20, 2023
@bradzacher bradzacher mentioned this pull request Mar 20, 2023
Closed
1 task
@bradzacher bradzacher merged commit 91b7d9f into typescript-eslint:main Mar 20, 2023
@sosukesuzuki sosukesuzuki deleted the update-ts-5 branch March 20, 2023 05:19
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg requested changes

Assignees
No one assigned
Labels
dependencies Issue about dependencies of the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sosukesuzuki @JoshuaKGoldberg @bradzacher
0