8000 test(ast-spec): update `@babel/parser` by sosukesuzuki · Pull Request #6599 · typescript-eslint/typescript-eslint · GitHub
[go: up one dir, main page]

Skip to content

test(ast-spec): update @babel/parser #6599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sosukesuzuki
Copy link
Contributor
@sosukesuzuki sosukesuzuki commented Mar 11, 2023

PR Checklist

Overview

Updates @babel/parser to 7.21.

@babel/parser 7.21 supports export type * declarations. So this PR updates tests for it.

This change is required by working on #6380, I would appreciate a review sooner rather than later!

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @sosukesuzuki!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@nx-cloud
Copy link
nx-cloud bot commented Mar 11, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 13ebf46. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 46 targets

Sent with 💌 from NxCloud.

@netlify
Copy link
netlify bot commented Mar 11, 2023

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 13ebf46
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/640cbaf7f6daee0008dd20a1
😎 Deploy Preview https://deploy-preview-6599--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link
codecov bot commented Mar 11, 2023

Codecov Report

Merging #6599 (13ebf46) into main (9427b7c) will increase coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6599      +/-   ##
==========================================
+ Coverage   90.66%   90.67%   +0.01%     
==========================================
  Files         376      376              
  Lines       12851    12849       -2     
  Branches     3783     3783              
==========================================
  Hits        11651    11651              
+ Misses        856      854       -2     
  Partials      344      344              
Flag Coverage Δ
unittest 90.67% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

Copy link
Member
@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this!

},
],
- sourceType: 'module',
+ sourceType: 'script',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow really - babel doesn't think that export type * from 'a'; should be considered a module? That's surprising to me!

@bradzacher bradzacher added the tests anything to do with testing label Mar 13, 2023
@bradzacher bradzacher added this pull request to the merge queue Mar 13, 2023
@bradzacher bradzacher removed this pull request from the merge queue due to a manual request Mar 13, 2023
@bradzacher bradzacher merged commit 7fe41ff into typescript-eslint:main Mar 13, 2023
@sosukesuzuki sosukesuzuki deleted the update-babel-parser-7.21 branch March 16, 2023 01:09
hasparus pushed a commit to hasparus/typescript-eslint that referenced this pull request Mar 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tests anything to do with testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0