-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
test(ast-spec): update @babel/parser
#6599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(ast-spec): update @babel/parser
#6599
Conversation
Thanks for the PR, @sosukesuzuki! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6599 +/- ##
==========================================
+ Coverage 90.66% 90.67% +0.01%
==========================================
Files 376 376
Lines 12851 12849 -2
Branches 3783 3783
==========================================
Hits 11651 11651
+ Misses 856 854 -2
Partials 344 344
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for this!
}, | ||
], | ||
- sourceType: 'module', | ||
+ sourceType: 'script', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow really - babel doesn't think that export type * from 'a';
should be considered a module? That's surprising to me!
PR Checklist
Overview
Updates
@babel/parser
to 7.21.@babel/parser
7.21 supportsexport type *
declarations. So this PR updates tests for it.This change is required by working on #6380, I would appreciate a review sooner rather than later!