8000 feat(eslint-plugin): [naming-convention] add support for `#private` modifier on class members by hlysine · Pull Request #6259 · typescript-eslint/typescript-eslint · GitHub
[go: up one dir, main page]
Skip to content

feat(eslint-plugin): [naming-convention] add support for #private modifier on class members #6259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 22, 2023
Merged

feat(eslint-plugin): [naming-convention] add support for #private modifier on class members #6259

merged 5 commits into from
Jan 22, 2023

Conversation

hlysine
Copy link
Contributor
@hlysine hlysine commented Dec 21, 2022

PR Checklist

Overview

Currently, a class member with a private identifier (#private) is essentially treated as one with a public modifier. This PR adds the #private modifier option to target this kind of member.

@hlysine
Add #private as a modifier
5eb8560 
Numbers for TypeModifiers are changed as instructed by the comment in the Modifiers enum
@hlysine
Add support for #private modifier
f96ca0c
@hlysine
Add tests
695c8a5
@hlysine
Add docs
4cfd58f
@nx-cloud
Copy link
nx-cloud bot commented Dec 21, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 8c95e78. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @hlysine!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link
netlify bot commented Dec 21, 2022 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 8c95e78
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/63ccd0a4a281530008d6516b
😎 Deploy Preview https://deploy-preview-6259--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link
codecov bot commented Dec 21, 2022 •
edited
Loading

Codecov Report

Merging #6259 (8c95e78) into main (503bfde) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6259   +/-   ##
=======================================
  Coverage   91.27%   91.27%           
=======================================
  Files         366      366           
  Lines       12445    12447    +2     
  Branches     3645     3646    +1     
=======================================
+ Hits        11359    11361    +2     
  Misses        772      772           
  Partials      314      314
Flag Coverage Δ
unittest 91.27% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...-plugin/src/rules/naming-convention-utils/enums.ts 100.00% <ø> (ø)
...plugin/src/rules/naming-convention-utils/schema.ts 100.00% <ø> (ø)
...kages/eslint-plugin/src/rules/naming-convention.ts 82.02% <100.00%> (+0.16%) ⬆️

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Jan 22, 2023
View reviewed changes
Copy link
Member
@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! 🚀

This rule & its tests don't quite adhere to the same standards the rest of the codebase does, such as having one behavior under test per test case... eventually I'll have the energy to file an issue about cleaning it up. Eventually. 🫠

@JoshuaKGoldberg JoshuaKGoldberg enabled auto-merge (squash) January 22, 2023 05:59
@JoshuaKGoldberg JoshuaKGoldberg merged commit c8a6d80 into typescript-eslint:main Jan 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhancement: [naming-convention] add support for #private members
2 participants
@hlysine @JoshuaKGoldberg
0