8000 chore(eslint-plugin): comma-spacing meta.type should be layout, not suggestion by JoshuaKGoldberg · Pull Request #5705 · typescript-eslint/typescript-eslint · GitHub
[go: up one dir, main page]
Skip to content

chore(eslint-plugin): comma-spacing meta.type should be layout, not suggestion #5705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2022
Merged

chore(eslint-plugin): comma-spacing meta.type should be layout, not suggestion #5705

merged 1 commit into from
Oct 4, 2022

Conversation

JoshuaKGoldberg
Copy link
Member
@JoshuaKGoldberg JoshuaKGoldberg commented Oct 1, 2022 •
edited
Loading

PR Checklist

Overview

Found as part of #5696.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@nx-cloud
Copy link
nx-cloud bot commented Oct 1, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f9beb00. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@netlify
Copy link
netlify bot commented Oct 1, 2022 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

8000
Name Link
🔨 Latest commit f9beb00
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6337d603642b3a0008924894
😎 Deploy Preview https://deploy-preview-5705--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review October 1, 2022 06:03
@codecov
Copy link
codecov bot commented Oct 1, 2022 •
edited
Loading

Codecov Report

Merging #5705 (f9beb00) into main (c8d5cd2) will increase coverage by 0.11%.
The diff coverage is n/a.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5705      +/-   ##
==========================================
+ Coverage   93.82%   93.94%   +0.11%     
==========================================
  Files         134      288     +154     
  Lines        1506     9575    +8069     
  Branches      226     2880    +2654     
==========================================
+ Hits         1413     8995    +7582     
- Misses         60      333     +273     
- Partials       33      247     +214
Flag Coverage Δ
unittest 93.94% <ø> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/eslint-plugin/src/rules/comma-spacing.ts 100.00% <ø> (ø)
packages/eslint-plugin/src/rules/require-await.ts 90.47% <0.00%> (ø)
...s/eslint-plugin/src/rules/no-non-null-assertion.ts 87.09% <0.00%> (ø)
...gin/src/rules/non-nullable-type-assertion-style.ts 100.00% <0.00%> (ø)
...ackages/eslint-plugin/src/rules/no-implied-eval.ts 97.05% <0.00%> (ø)
...ackages/eslint-plugin/src/rules/prefer-includes.ts 97.72% <0.00%> (ø)
...int-plugin/src/rules/strict-boolean-expressions.ts 98.83% <0.00%> (ø)
packages/eslint-plugin/src/rules/no-this-alias.ts 100.00% <0.00%> (ø)
...ges/eslint-plugin/src/rules/no-misused-promises.ts 98.35% <0.00%> (ø)
packages/eslint-plugin/src/configs/recommended.ts 100.00% <0.00%> (ø)
... and 145 more

@bradzacher bradzacher merged commit 2d1e034 into typescript-eslint:main Oct 4, 2022
@JoshuaKGoldberg JoshuaKGoldberg deleted the comma-spacing-fix branch October 4, 2022 11:49
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: [comma-spacing] meta.type should be layout, not suggestion
2 participants
@JoshuaKGoldberg @bradzacher
0