feat(eslint-plugin): add strict-comparisons rule #5648
Conversation
Signed-off-by: Nguyen Le Vu Long <vulongvn98@gmail.com>
|
Thanks for the PR, @longngn! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5648 +/- ##
=======================================
Coverage 93.59% 93.60%
=======================================
Files 288 289 +1
Lines 9575 9649 +74
Branches 2880 2902 +22
=======================================
+ Hits 8962 9032 +70
- Misses 334 336 +2
- Partials 279 281 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
You checked this part of the PR template, but the issue is not marked as accepting PRs 😉. It's generally a good idea to wait for the discussion to be resolved before sending a nontrivial PR like this one. |
|
Given the above issue is marked as blocked and also in a limbo state as to whether its going to be accepted I'm going to close this PR for now. If we do decide to move forward with the issue - we can reopen this PR at that date! |
Signed-off-by: Nguyen Le Vu Long vulongvn98@gmail.com
PR Checklist
Overview
Continue working on code from #314
Let's try to get this finally merged, this rule is absolutely necessary.