typescript-eslint · bradzacher · Aug 30, 2022 · Feb 19, 2023 · Feb 19, 2023 · Feb 19, 2023
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -26,6 +26,7 @@ module.exports = {
       './tsconfig.eslint.json',
       './packages/*/tsconfig.json',
       './tests/integration/tsconfig.json',
+      './tools/tsconfig.json',
       /**
        * We are currently in the process of transitioning to nx's out of the box structure and
        * so need to manually specify converted packages' tsconfig.build.json and tsconfig.spec.json

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -11,7 +11,9 @@ on:
   merge_group:
 
 env:
+  PRIMARY_ESLINT_VERSION: '^8.0.0'
   PRIMARY_NODE_VERSION: 18
+  PRIMARY_TYPESCRIPT_VERSION: '~4.8.0'
   # Only set the read-write token if we are on the main branch
   NX_CLOUD_ACCESS_TOKEN: ${{ github.event_name == 'push' && github.ref == 'refs/heads/main' && secrets.NX_CLOUD_ACCESS_TOKEN }}
 
@@ -61,6 +63,7 @@ jobs:
     needs: [install]
     runs-on: ubuntu-latest
     strategy:
+      fail-fast: false
       matrix:
         lint-task: ['check-spelling', 'check-format', 'lint-markdown']
     steps:
@@ -80,6 +83,7 @@ jobs:
     needs: [build]
     runs-on: ubuntu-latest
     strategy:
+      fail-fast: false
       matrix:
         lint-task: ['lint', 'typecheck']
     steps:
@@ -119,8 +123,10 @@ jobs:
     needs: [build]
     runs-on: ubuntu-latest
     strategy:
+      fail-fast: false
       matrix:
         # just run on the oldest and latest supported versions and assume the intermediate versions are good
+        # unfortunately you can't reference environment variables in an array :(
         node-version: [14, 18]
         package:
           [
@@ -176,6 +182,104 @@ jobs:
           # Sadly 1 day is the minimum
           retention-days: 1
 
+  unit_tests_ts_regression:
+    name: Run Unit Tests (TypeScript Version Regression Checks)
+    needs: [build]
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        package:
+          # note that we don't regression test all packages here on purpose because most don't depend on TS directly.
+          ['eslint-plugin', 'scope-manager', 'type-utils', 'typescript-estree']
+
+        ts-version:
+          # unfortunately you can't reference environment variables in an array :(
+          [
+            # lowest possible version
+            '4.2.4',
+            # somewhere in the middle for sanity check
+            '~4.5.5',
+            # highest possible version
+            '~4.8.2',
+          ]
+    env:
+      # Added the - at the end to function as a separator to improve readability in the PR comment from the Nx cloud app
+      NX_CLOUD_ENV_NAME: 'Node ${{ matrix.node-version }} -'
+      COLLECT_COVERAGE: false
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v3
+        with:
+          fetch-depth: 2
+      - name: Install
+        uses: ./.github/actions/prepare-install
+        with:
+          node-version: ${{ env.PRIMARY_NODE_VERSION }}
+      - name: Build
+        uses: ./.github/actions/prepare-build
+
+      - name: Install Specific TS Version
+        run: |
+          yarn ts-node ./tools/change-ts-version.ts ${{ matrix.ts-version }}
+          yarn --ignore-engines --ignore-scripts
+
+      - name: Patch Packages
+        if: matrix.ts-version == env.PRIMARY_TYPESCRIPT_VERSION
+        run: |
+          yarn patch-package
+
+      # we don't collect coverage for these tests on purpose
+      - name: Run unit tests for ${{ matrix.package }}
+        run: npx nx test ${{ matrix.package }} --coverage=false
+        env:
+          CI: true
+
+  unit_tests_eslint_regression:
+    name: Run Unit Tests (ESLint Version Regression Checks)
+    needs: [build]
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        package:
+          # note that we don't regression test all packages here on purpose because most don't depend on ESLint directly.
+          ['eslint-plugin', 'utils']
+        eslint-version:
+          # unfortunately you can't reference environment variables in an array :(
+          [
+            # lowest possible version
+            '6.0.0',
+            # somewhere in the middle for sanity check
+            '7.32.0',
+            # highest possible version
+            '^8.0.0',
+          ]
+    env:
+      # Added the - at the end to function as a separator to improve readability in the PR comment from the Nx cloud app
+      NX_CLOUD_ENV_NAME: 'Node ${{ matrix.node-version }} -'
+      COLLECT_COVERAGE: false
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v3
+        with:
+          fetch-depth: 2
+      - name: Install
+        uses: ./.github/actions/prepare-install
+        with:
+          node-version: ${{ env.PRIMARY_NODE_VERSION }}
+      - name: Build
+        uses: ./.github/actions/prepare-build
+
+      - name: Install Specific ESLint Version
+        run: yarn add -DW --ignore-engines --ignore-scripts eslint@${{ matrix.eslint-version }}
+
+      # we don't collect coverage for these tests on purpose
+      - name: Run unit tests for ${{ matrix.package }}
+        run: npx nx test ${{ matrix.package }} --coverage=false
+        env:
+          CI: true
+
   website_tests:
     permissions:
       contents: read # to fetch code (actions/checkout)

diff --git a/packages/ast-spec/package.json b/packages/ast-spec/package.json
@@ -48,12 +48,14 @@
     "@babel/parser": "*",
     "@microsoft/api-extractor": "^7.23.2",
     "@types/babel__core": "*",
+    "eslint": "*",
     "glob": "*",
     "jest-diff": "*",
     "jest-snapshot": "*",
     "jest-specific-snapshot": "*",
     "make-dir": "*",
     "pretty-format": "*",
+    "semver": "*",
     "typescript": "*"
   }
 }
diff --git a/packages/ast-spec/src/declaration/ExportAllDeclaration/fixtures/assertion/config.json b/packages/ast-spec/src/declaration/ExportAllDeclaration/fixtures/assertion/config.json
@@ -0,0 +1,3 @@
+{
+  "typescript": ">=4.9"
+}
diff --git a/...es/ast-spec/src/declaration/ExportNamedDeclaration/fixtures/_error_/assertion/config.json b/...es/ast-spec/src/declaration/ExportNamedDeclaration/fixtures/_error_/assertion/config.json
@@ -0,0 +1,3 @@
+{
+  "typescript": ">=4.9"
+}
diff --git a/packages/ast-spec/src/declaration/ImportDeclaration/fixtures/assertion/config.json b/packages/ast-spec/src/declaration/ImportDeclaration/fixtures/assertion/config.json
@@ -0,0 +1,3 @@
+{
+  "typescript": ">=4.9"
+}
diff --git a/...s/ast-spec/src/declaration/TSInterfaceDeclaration/fixtures/_error_/missing-id/config.json b/...s/ast-spec/src/declaration/TSInterfaceDeclaration/fixtures/_error_/missing-id/config.json
@@ -0,0 +1,3 @@
+{
+  "typescript": ">=4.9"
+}
diff --git a/...c/src/declaration/TSInterfaceDeclaration/fixtures/_error_/non-identifier-name/config.json b/...c/src/declaration/TSInterfaceDeclaration/fixtures/_error_/non-identifier-name/config.json
@@ -0,0 +1,3 @@
+{
+  "typescript": ">=4.9"
+}
diff --git a/...t-spec/src/declaration/TSModuleDeclaration/fixtures/_error_/module-invalid-id/config.json b/...t-spec/src/declaration/TSModuleDeclaration/fixtures/_error_/module-invalid-id/config.json
@@ -0,0 +1,3 @@
+{
+  "typescript": ">=4.9"
+}
diff --git a/...pec/src/declaration/TSModuleDeclaration/fixtures/_error_/namespace-invalid-id/config.json b/...pec/src/declaration/TSModuleDeclaration/fixtures/_error_/namespace-invalid-id/config.json
@@ -0,0 +1,3 @@
+{
+  "typescript": ">=4.9"
+}
diff --git a/...c/src/declaration/TSTypeAliasDeclaration/fixtures/_error_/non-identifier-name/config.json b/...c/src/declaration/TSTypeAliasDeclaration/fixtures/_error_/non-identifier-name/config.json
@@ -0,0 +1,3 @@
+{
+  "typescript": ">=4.9"
+}
diff --git a/...c/element/AccessorProperty/fixtures/_error_/modifier-override-with-no-extends/config.json b/...c/element/AccessorProperty/fixtures/_error_/modifier-override-with-no-extends/config.json
@@ -0,0 +1,3 @@
+{
+  "typescript": ">=4.9"
+}
diff --git a/packages/ast-spec/src/element/AccessorProperty/fixtures/key-computed-complex/config.json b/packages/ast-spec/src/element/AccessorProperty/fixtures/key-computed-complex/config.json
@@ -0,0 +1,3 @@
+{
+  "typescript": ">=4.9"
+}
diff --git a/packages/ast-spec/src/element/AccessorProperty/fixtures/key-computed-number/config.json b/packages/ast-spec/src/element/AccessorProperty/fixtures/key-computed-number/config.json
@@ -0,0 +1,3 @@
+{
+  "typescript": ">=4.9"
+}
diff --git a/packages/ast-spec/src/element/AccessorProperty/fixtures/key-computed-string/config.json b/packages/ast-spec/src/element/AccessorProperty/fixtures/key-computed-string/config.json
@@ -0,0 +1,3 @@
+{
+  "typescript": ">=4.9"
+}
diff --git a/packages/ast-spec/src/element/AccessorProperty/fixtures/key-private/config.json b/packages/ast-spec/src/element/AccessorProperty/fixtures/key-private/config.json
@@ -0,0 +1,3 @@
+{
+  "typescript": ">=4.9"
+}
diff --git a/packages/ast-spec/src/element/AccessorProperty/fixtures/key-string/config.json b/packages/ast-spec/src/element/AccessorProperty/fixtures/key-string/config.json
@@ -0,0 +1,3 @@
+{
+  "typescript": ">=4.9"
+}
diff --git a/...s/ast-spec/src/element/AccessorProperty/fixtures/modifier-abstract-with-value/config.json b/...s/ast-spec/src/element/AccessorProperty/fixtures/modifier-abstract-with-value/config.json
@@ -0,0 +1,3 @@
+{
+  "typescript": ">=4.9"
+}
diff --git a/packages/ast-spec/src/element/AccessorProperty/fixtures/modifier-abstract/config.json b/packages/ast-spec/src/element/AccessorProperty/fixtures/modifier-abstract/config.json
@@ -0,0 +1,3 @@
+{
+  "typescript": ">=4.9"
+}
diff --git a/packages/ast-spec/src/element/AccessorProperty/fixtures/modifier-declare/config.json b/packages/ast-spec/src/element/AccessorProperty/fixtures/modifier-declare/config.json
@@ -0,0 +1,3 @@
+{
+  "typescript": ">=4.9"
+}
diff --git a/packages/ast-spec/src/element/AccessorProperty/fixtures/modifier-override/config.json b/packages/ast-spec/src/element/AccessorProperty/fixtures/modifier-override/config.json
@@ -0,0 +1,3 @@
+{
+  "typescript": ">=4.9"
+}
diff --git a/packages/ast-spec/src/element/AccessorProperty/fixtures/modifier-private/config.json b/packages/ast-spec/src/element/AccessorProperty/fixtures/modifier-private/config.json
@@ -0,0 +1,3 @@
+{
+  "typescript": ">=4.9"
+}
diff --git a/packages/ast-spec/src/element/AccessorProperty/fixtures/modifier-protected/config.json b/packages/ast-spec/src/element/AccessorProperty/fixtures/modifier-protected/config.json
@@ -0,0 +1,3 @@
+{
+  "typescript": ">=4.9"
+}
diff --git a/packages/ast-spec/src/element/AccessorProperty/fixtures/modifier-public/config.json b/packages/ast-spec/src/element/AccessorProperty/fixtures/modifier-public/config.json
@@ -0,0 +1,3 @@
+{
+  "typescript": ">=4.9"
+}
diff --git a/packages/ast-spec/src/element/AccessorProperty/fixtures/modifier-readonly/config.json b/packages/ast-spec/src/element/AccessorProperty/fixtures/modifier-readonly/config.json
@@ -0,0 +1,3 @@
+{
+  "typescript": ">=4.9"
+}
diff --git a/packages/ast-spec/src/element/AccessorProperty/fixtures/modifier-static/config.json b/packages/ast-spec/src/element/AccessorProperty/fixtures/modifier-static/config.json
@@ -0,0 +1,3 @@
+{
+  "typescript": ">=4.9"
+}
diff --git a/packages/ast-spec/src/element/AccessorProperty/fixtures/no-annotation-no-value/config.json b/packages/ast-spec/src/element/AccessorProperty/fixtures/no-annotation-no-value/config.json
@@ -0,0 +1,3 @@
+{
+  "typescript": ">=4.9"
+}
diff --git a/packages/ast-spec/src/element/AccessorProperty/fixtures/no-annotation-with-value/config.json b/packages/ast-spec/src/element/AccessorProperty/fixtures/no-annotation-with-value/config.json
@@ -0,0 +1,3 @@
+{
+  "typescript": ">=4.9"
+}
diff --git a/packages/ast-spec/src/element/AccessorProperty/fixtures/with-annotation-no-value/config.json b/packages/ast-spec/src/element/AccessorProperty/fixtures/with-annotation-no-value/config.json
@@ -0,0 +1,3 @@
+{
+  "typescript": ">=4.9"
+}
diff --git a/...ges/ast-spec/src/element/AccessorProperty/fixtures/with-annotation-with-value/config.json b/...ges/ast-spec/src/element/AccessorProperty/fixtures/with-annotation-with-value/config.json
@@ -0,0 +1,3 @@
+{
+  "typescript": ">=4.9"
+}
diff --git a/packages/ast-spec/src/expression/TSSatisfiesExpression/fixtures/array-array/config.json b/packages/ast-spec/src/expression/TSSatisfiesExpression/fixtures/array-array/config.json
@@ -0,0 +1,3 @@
+{
+  "typescript": ">=4.9"
+}
diff --git a/...-spec/src/expression/TSSatisfiesExpression/fixtures/arrow-func-no-parentheses/config.json b/...-spec/src/expression/TSSatisfiesExpression/fixtures/arrow-func-no-parentheses/config.json
@@ -0,0 +1,3 @@
+{
+  "typescript": ">=4.9"
+}
diff --git a/...pec/src/expression/TSSatisfiesExpression/fixtures/arrow-func-with-parentheses/config.json b/...pec/src/expression/TSSatisfiesExpression/fixtures/arrow-func-with-parentheses/config.json
@@ -0,0 +1,3 @@
+{
+  "typescript": ">=4.9"
+}
diff --git a/...ages/ast-spec/src/expression/TSSatisfiesExpression/fixtures/chained-satisfies/config.json b/...ages/ast-spec/src/expression/TSSatisfiesExpression/fixtures/chained-satisfies/config.json
@@ -0,0 +1,3 @@
+{
+  "typescript": ">=4.9"
+}
diff --git a/...spec/src/expression/TSSatisfiesExpression/fixtures/conditional-no-parentheses/config.json b/...spec/src/expression/TSSatisfiesExpression/fixtures/conditional-no-parentheses/config.json
@@ -0,0 +1,3 @@
+{
+  "typescript": ">=4.9"
+}
diff --git a/...ec/src/expression/TSSatisfiesExpression/fixtures/conditional-with-parentheses/config.json b/...ec/src/expression/TSSatisfiesExpression/fixtures/conditional-with-parentheses/config.json
@@ -0,0 +1,3 @@
+{
+  "typescript": ">=4.9"
+}
diff --git a/...ges/ast-spec/src/expression/TSSatisfiesExpression/fixtures/identifier-keyword/config.json b/...ges/ast-spec/src/expression/TSSatisfiesExpression/fixtures/identifier-keyword/config.json
@@ -0,0 +1,3 @@
+{
+  "typescript": ">=4.9"
+}
diff --git a/...ast-spec/src/expression/TSSatisfiesExpression/fixtures/identifier-object-type/config.json b/...ast-spec/src/expression/TSSatisfiesExpression/fixtures/identifier-object-type/config.json
@@ -0,0 +1,3 @@
+{
+  "typescript": ">=4.9"
+}
diff --git a/.../ast-spec/src/expression/TSSatisfiesExpression/fixtures/identifier-tuple-type/config.json b/.../ast-spec/src/expression/TSSatisfiesExpression/fixtures/identifier-tuple-type/config.json
@@ -0,0 +1,3 @@
+{
+  "typescript": ">=4.9"
+}
diff --git a/...ast-spec/src/expression/TSSatisfiesExpression/fixtures/logical-no-parentheses/config.json b/...ast-spec/src/expression/TSSatisfiesExpression/fixtures/logical-no-parentheses/config.json
@@ -0,0 +1,3 @@
+{
+  "typescript": ">=4.9"
+}
diff --git a/...t-spec/src/expression/TSSatisfiesExpression/fixtures/logical-with-parentheses/config.json b/...t-spec/src/expression/TSSatisfiesExpression/fixtures/logical-with-parentheses/config.json
@@ -0,0 +1,3 @@
+{
+  "typescript": ">=4.9"
+}
diff --git a/...src/expression/TSSatisfiesExpression/fixtures/object-object-inner-parentheses/config.json b/...src/expression/TSSatisfiesExpression/fixtures/object-object-inner-parentheses/config.json
@@ -0,0 +1,3 @@
+{
+  "typescript": ">=4.9"
+}
diff --git a/...src/expression/TSSatisfiesExpression/fixtures/object-object-outer-parentheses/config.json b/...src/expression/TSSatisfiesExpression/fixtures/object-object-outer-parentheses/config.json
@@ -0,0 +1,3 @@
+{
+  "typescript": ">=4.9"
+}
diff --git a/...legacy-fixtures/basics/fixtures/_error_/abstract-class-with-override-property/config.json b/...legacy-fixtures/basics/fixtures/_error_/abstract-class-with-override-property/config.json
@@ -0,0 +1,3 @@
+{
+  "typescript": ">=4.9"
+}
diff --git a/...pec/src/legacy-fixtures/basics/fixtures/_error_/export-with-import-assertions/config.json b/...pec/src/legacy-fixtures/basics/fixtures/_error_/export-with-import-assertions/config.json
@@ -0,0 +1,3 @@
+{
+  "typescript": ">=4.9"
+}
diff --git a/...-spec/src/legacy-fixtures/basics/fixtures/abstract-class-with-override-method/config.json b/...-spec/src/legacy-fixtures/basics/fixtures/abstract-class-with-override-method/config.json
@@ -0,0 +1,3 @@
+{
+  "typescript": ">=4.9"
+}
diff --git a/packages/ast-spec/src/legacy-fixtures/basics/fixtures/class-static-blocks/config.json b/packages/ast-spec/src/legacy-fixtures/basics/fixtures/class-static-blocks/config.json
@@ -0,0 +1,3 @@
+{
+  "typescript": ">=4.9"
+}
diff --git a/.../basics/fixtures/class-with-constructor-and-parameter-property-with-modifiers/config.json b/.../basics/fixtures/class-with-constructor-and-parameter-property-with-modifiers/config.json
@@ -0,0 +1,3 @@
+{
+  "typescript": ">=4.9"
+}
diff --git a/...fixtures/class-with-constructor-and-parameter-proptery-with-override-modifier/config.json b/...fixtures/class-with-constructor-and-parameter-proptery-with-override-modifier/config.json
@@ -0,0 +1,3 @@
+{
+  "typescript": ">=4.9"
+}
diff --git a/packages/ast-spec/src/legacy-fixtures/basics/fixtures/class-with-override-method/config.json b/packages/ast-spec/src/legacy-fixtures/basics/fixtures/class-with-override-method/config.json
@@ -0,0 +1,3 @@
+{
+  "typescript": ">=4.9"
+}
diff --git a/...ges/ast-spec/src/legacy-fixtures/basics/fixtures/class-with-override-property/config.json b/...ges/ast-spec/src/legacy-fixtures/basics/fixtures/class-with-override-property/config.json
@@ -0,0 +1,3 @@
+{
+  "typescript": ">=4.9"
+}
diff --git a/...st-spec/src/legacy-fixtures/basics/fixtures/export-all-with-import-assertions/config.json b/...st-spec/src/legacy-fixtures/basics/fixtures/export-all-with-import-assertions/config.json
@@ -0,0 +1,3 @@
+{
+  "typescript": ">=4.9"
+}
diff --git a/...es/ast-spec/src/legacy-fixtures/basics/fixtures/import-with-import-assertions/config.json b/...es/ast-spec/src/legacy-fixtures/basics/fixtures/import-with-import-assertions/config.json
@@ -0,0 +1,3 @@
+{
+  "typescript": ">=4.9"
+}
diff --git a/packages/ast-spec/src/legacy-fixtures/basics/fixtures/private-fields-in-in/config.json b/packages/ast-spec/src/legacy-fixtures/basics/fixtures/private-fields-in-in/config.json
@@ -0,0 +1,3 @@
+{
+  "typescript": ">=4.9"
+}
diff --git a/...ages/ast-spec/src/legacy-fixtures/basics/fixtures/type-only-export-specifiers/config.json b/...ages/ast-spec/src/legacy-fixtures/basics/fixtures/type-only-export-specifiers/config.json
@@ -0,0 +1,3 @@
+{
+  "typescript": ">=4.9"
+}
diff --git a/...ages/ast-spec/src/legacy-fixtures/basics/fixtures/type-only-import-specifiers/config.json b/...ages/ast-spec/src/legacy-fixtures/basics/fixtures/type-only-import-specifiers/config.json
@@ -0,0 +1,3 @@
+{
+  "typescript": ">=4.9"
+}
diff --git a/...pec/src/legacy-fixtures/expressions/fixtures/_error_/instantiation-expression/config.json b/...pec/src/legacy-fixtures/expressions/fixtures/_error_/instantiation-expression/config.json
@@ -0,0 +1,3 @@
+{
+  "typescript": ">=4.9"
+}
diff --git a/...ast-spec/src/legacy-fixtures/types/fixtures/conditional-infer-with-constraint/config.json b/...ast-spec/src/legacy-fixtures/types/fixtures/conditional-infer-with-constraint/config.json
@@ -0,0 +1,3 @@
+{
+  "typescript": ">=4.9"
+}
diff --git a/packages/ast-spec/src/legacy-fixtures/types/fixtures/interface-with-accessors/config.json b/packages/ast-spec/src/legacy-fixtures/types/fixtures/interface-with-accessors/config.json
@@ -0,0 +1,3 @@
+{
+  "typescript": ">=4.9"
+}
diff --git a/...st-spec/src/legacy-fixtures/types/fixtures/object-literal-type-with-accessors/config.json b/...st-spec/src/legacy-fixtures/types/fixtures/object-literal-type-with-accessors/config.json
@@ -0,0 +1,3 @@
+{
+  "typescript": ">=4.9"
+}
diff --git a/...ages/ast-spec/src/legacy-fixtures/types/fixtures/optional-variance-in-and-out/config.json b/...ages/ast-spec/src/legacy-fixtures/types/fixtures/optional-variance-in-and-out/config.json
@@ -0,0 +1,3 @@
+{
+  "typescript": ">=4.9"
+}