8000 chore: update dependencies by MichaelDeBoey · Pull Request #3859 · typescript-eslint/typescript-eslint · GitHub
[go: up one dir, main page]
Skip to content

chore: update dependencies #3859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 18, 2021
Merged

chore: update dependencies #3859

merged 1 commit into from
Oct 18, 2021

Conversation

MichaelDeBoey
Copy link
Contributor
@MichaelDeBoey MichaelDeBoey commented Sep 8, 2021 •
edited
Loading

Update all dependencies to their latest minor version.
Also ran nx migrate latest

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @MichaelDeBoey!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@nx-cloud
Copy link
nx-cloud bot commented Sep 8, 2021 •
edited
Loading

Nx Cloud Report

CI ran the following commands for commit 517fdac. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin-internal
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 14.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 14.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 16.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 16.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 12.x - nx run-many --target=typecheck --all --parallel
#000000 Node 12.x - nx test @typescript-eslint/parser
#000000 Node 12.x - nx test @typescript-eslint/experimental-utils
#000000 Node 12.x - nx test @typescript-eslint/scope-manager
#000000 Node 12.x - nx test @typescript-eslint/visitor-keys
#000000 Node 12.x - nx test @typescript-eslint/typescript-estree
#000000 Node 12.x - nx run-many --target=build --all --parallel
#000000 Node 12.x - nx run-many --target=build --all --parallel
#000000 Node 14.x - nx test @typescript-eslint/parser
#000000 Node 14.x - nx test @typescript-eslint/experimental-utils
#000000 Node 12.x - nx run-many --target=build --all --parallel

Sent with 💌 from NxCloud.

bradzacher
bradzacher reviewed Sep 8, 2021
View reviewed changes
@bradzacher bradzacher added the dependencies Issue about dependencies of the package label Sep 9, 2021
MichaelDeBoey
MichaelDeBoey commented Sep 9, 2021
View reviewed changes
@bradzacher bradzacher added the awaiting response Issues waiting for a reply from the OP or another party label Sep 20, 2021
@MichaelDeBoey MichaelDeBoey force-pushed the update-dependencies branch 4 times, most recently from 35d3712 to 74a3a8c Compare September 21, 2021 16:24
@bradzacher
Copy link
Member

To fix the CI:

  1. undo the upgrade for eslint-visitor-keys in our visitor-keys package.
    • We are upgrading to v3 of their package in our v5 branch so we'll just sit on this older version until then (word on the street is eslint v8 will be out in a few weeks so we'll release v5 then too)
  2. looks like a test has some test cases that need to be reformatted to match the new prettier version
    • packages/eslint-plugin/tests/rules/no-type-alias.test.ts

@MichaelDeBoey MichaelDeBoey force-pushed the update-dependencies branch 3 times, most recently from 3570099 to ffa4657 Compare September 22, 2021 10:30
@MichaelDeBoey MichaelDeBoey force-pushed the update-dependencies branch 2 times, most recently from 8cf84d1 to a22719f Compare October 5, 2021 22:41
@bradzacher
Copy link
Member

we'll need to fix the two unit test failures before we can merge this

@MichaelDeBoey MichaelDeBoey force-pushed the update-dependencies branch 2 times, most recently from 47933a0 to b7a4edc Compare October 7, 2021 20:19
@MichaelDeBoey
8000 Copy link
Contributor Author

@bradzacher I think this one can be merged

@bradzacher
Copy link
Member

https://github.com/typescript-eslint/typescript-eslint/runs/3831798465#step:13:18

Looks like there's still some failures

@MichaelDeBoey
Copy link
Contributor Author
MichaelDeBoey commented Oct 7, 2021 •
edited
Loading

@bradzacher Seems like that one test isn't invalid anymore now. Should I remove it or is something broken?
https://github.com/typescript-eslint/typescript-eslint/pull/3859/checks?check_run_id=3832041194#step:14:116

@bradzacher
Copy link
Member

I was about to double check this but the force-push nuked the run history.
It looks like because of all the changes from the v5 branch this is now conflicting.

@MichaelDeBoey MichaelDeBoey force-pushed the update-dependencies branch 2 times, most recently from 4e3eec4 to 113db87 Compare October 14, 2021 11:20
@codecov
Copy link
codecov bot commented Oct 14, 2021 •
edited
Loading

Codecov Report

Merging #3859 (517fdac) into master (c51eef1) will decrease coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3859      +/-   ##
==========================================
- Coverage   93.40%   93.32%   -0.08%     
==========================================
  Files         151      151              
  Lines        8093     7940     -153     
  Branches     2568     2543      -25     
==========================================
- Hits         7559     7410     -149     
+ Misses        181      180       -1     
+ Partials      353      350       -3
Flag Coverage Δ
unittest 93.32% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/eslint-plugin/src/util/escapeRegExp.ts 75.00% <0.00%> (-5.00%) ⬇️
packages/eslint-plugin/src/util/propertyTypes.ts 87.50% <0.00%> (-1.39%) ⬇️
...ackages/eslint-plugin/src/rules/no-var-requires.ts 87.50% <0.00%> (-1.39%) ⬇️
...ages/eslint-plugin/src/rules/unified-signatures.ts 91.89% <0.00%> (-0.80%) ⬇️
...plugin/src/rules/no-unnecessary-type-constraint.ts 85.00% <0.00%> (-0.72%) ⬇️
packages/eslint-plugin/src/rules/quotes.ts 88.88% <0.00%> (-0.59%) ⬇️
packages/eslint-plugin/src/util/astUtils.ts 88.88% <0.00%> (-0.59%) ⬇️
...ges/eslint-plugin/src/rules/no-inferrable-types.ts 92.85% <0.00%> (-0.48%) ⬇️
...int-plugin/src/rules/consistent-type-assertions.ts 86.11% <0.00%> (-0.38%) ⬇️
...ages/eslint-plugin/src/rules/no-unsafe-argument.ts 84.88% <0.00%> (-0.35%) ⬇️
... and 70 more

@MichaelDeBoey
Copy link
Contributor Author

@bradzacher All seems to be green now, except codecov is complaining for some reason now

@bradzacher bradzacher removed the awaiting response Issues waiting for a reply from the OP or another party label Oct 18, 2021
@bradzacher bradzacher merged commit a75d9c8 into typescript-eslint:master Oct 18, 2021
@MichaelDeBoey 7242 MichaelDeBoey deleted the update-dependencies branch October 18, 2021 08:11
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
dependencies Issue about dependencies of the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaelDeBoey @bradzacher
0