8000 feat: remove `TSParenthesizedType` by sonallux · Pull Request #3340 · typescript-eslint/typescript-eslint · GitHub
[go: up one dir, main page]
Skip to content

feat: remove TSParenthesizedType #3340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 22, 2021
Merged

feat: remove TSParenthesizedType #3340

merged 3 commits into from
Aug 22, 2021

Conversation

sonallux
Copy link
Contributor
@sonallux sonallux commented May 3, 2021

This PR removes the legacy TSParenthesizedType AST node. Babel 8 will also stop generating the TSParenthesizedType node (see babel/babel#12608).

fixes #3136

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @sonallux!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

8000

@bradzacher bradzacher added AST PRs and Issues about the AST structure breaking change This change will require a new major version to be released labels May 3, 2021
@sonallux sonallux force-pushed the 3136-remove-TSParenthesizedType branch from f11b510 to f66458b Compare May 10, 2021 14:02
@bradzacher bradzacher added this to the 5.0.0 milestone Aug 16, 2021
@bradzacher bradzacher changed the base branch from master to v5 August 21, 2021 22:14
@bradzacher bradzacher changed the title Remove TSParenthesizedType feat: remove TSParenthesizedType Aug 21, 2021
@nx-cloud
Copy link
nx-cloud bot commented Aug 22, 2021 •
edited
Loading

Nx Cloud Report

CI ran the following commands for commit 326117a. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx test @typescript-eslint/eslint-plugin-internal
#000000 nx test @typescript-eslint/eslint-plugin-tslint
#000000 nx test @typescript-eslint/eslint-plugin
#000000 nx test @typescript-eslint/eslint-plugin-tslint
#000000 nx test @typescript-eslint/eslint-plugin-tslint
#000000 nx test @typescript-eslint/eslint-plugin
#000000 nx test @typescript-eslint/eslint-plugin
#000000 nx test @typescript-eslint/eslint-plugin-tslint
#000000 nx test @typescript-eslint/eslint-plugin
#000000 nx run-many --target=typecheck --all --parallel
#000000 nx test @typescript-eslint/parser
#000000 nx test @typescript-eslint/experimental-utils
#000000 nx test @typescript-eslint/scope-manager
#000000 nx test @typescript-eslint/visitor-keys
#000000 nx test @typescript-eslint/typescript-estree
#000000 nx run-many --target=build --all --parallel
#000000 nx run-many --target=build --all --parallel
#000000 nx run-many --target=build --all --parallel

Sent with 💌 from NxCloud.

bradzacher
bradzacher approved these changes Aug 22, 2021
View reviewed changes
Copy link
Member
@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for your work on this!

@codecov
Copy link
codecov bot commented Aug 22, 2021 •
edited
Loading

Codecov Report

Merging #3340 (326117a) into v5 (48858c9) will < 8000 strong>decrease coverage by 0.21%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##               v5    #3340      +/-   ##
==========================================
- Coverage   93.42%   93.21%   -0.22%     
==========================================
  Files         147      152       +5     
  Lines        7804     8014     +210     
  Branches     2472     2528      +56     
==========================================
+ Hits         7291     7470     +179     
- Misses        176      188      +12     
- Partials      337      356      +19
Flag Coverage Δ
unittest 93.21% <88.88%> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nt-plugin/src/rules/indent-new-do-not-use/index.ts 98.13% <ø> (ø)
packages/eslint-plugin/src/rules/indent.ts 92.85% <ø> (ø)
packages/eslint-plugin/src/rules/no-type-alias.ts 100.00% <ø> (ø)
packages/eslint-plugin/src/rules/array-type.ts 98.61% <83.33%> (+1.27%) ⬆️
...ackages/eslint-plugin/src/rules/no-extra-parens.ts 90.41% <100.00%> (ø)
.../src/rules/sort-type-union-intersection-members.ts 92.53% <100.00%> (ø)
...plugin-internal/src/rules/prefer-ast-types-enum.ts 90.00% <0.00%> (ø)
...internal/src/rules/no-typescript-default-import.ts 100.00% <0.00%> (ø)
...lugin-internal/src/rules/plugin-test-formatting.ts 81.75% <0.00%> (ø)
...gin-internal/src/rules/no-poorly-typed-ts-props.ts 88.88% <0.00%> (ø)
... and 1 more

@bradzacher bradzacher merged commit 6631ee1 into typescript-eslint:v5 Aug 22, 2021
@sonallux sonallux deleted the 3136-remove-TSParenthesizedType branch August 22, 2021 07:04
bradzacher added a commit that referenced this pull request Sep 3, 2021
@sonallux @bradzacher
feat: remove TSParenthesizedType (#3340)
3845e18 
fixes #3136

Co-authored-by: Brad Zacher <brad.zacher@gmail.com>
bradzacher added a commit that referenced this pull request Sep 21, 2021
@sonallux @bradzacher
feat: remove TSParenthesizedType (#3340)
8b96290 
fixes #3136

Co-authored-by: Brad Zacher <brad.zacher@gmail.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
AST PRs and Issues about the AST structure breaking change This change will require a new major version to be released
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

Remove TSParenthesizedType
2 participants
@sonallux @bradzacher
0