-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
feat: add stable PrivateIdentifier based on estree spec #2933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## v5 #2933 +/- ##
==========================================
- Coverage 92.83% 92.82% -0.01%
==========================================
Files 314 314
Lines 10675 10680 +5
Branches 3027 3031 +4
==========================================
+ Hits 9910 9914 +4
Misses 348 348
- Partials 417 418 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Based on my discussion with them in estree/estree#240 - I'm happy for us to add these to the AST. |
@bradzacher I've raised such a PR here: estree/estree#241 Update: Resulted in estree/estree#242 which has now been merged. Full steam ahead! |
aedb035
to
f3a65a1
Compare
This might make sense in its own Issue rather than this PR, but adding here for continuity of the ESTree class-features spec theme: Can we reconcile the existing |
Yes that's definitely on the cards to do soon, but that is a breaking change, so it would be better as a separate change. |
I've created #3068 to track this following the completion of this PR. |
0d788cf
to
b249029
Compare
Closing in favour of #3808 |
Add stable PrivateIdentifier ts-estree base on estree spec,
Due to lack of spec this field field was read as is from typescript,
Changes to produced AST:
value
field got renamed toname
without initial#
TODO:
naming-convention
ruleno-unsafe-assignment
rulefixes #1436
ref #3430
estree spec: https://github.com/estree/estree/blob/master/experimental/class-features.md