fix(eslint-plugin): fix crash in no-unnecessary-type-assertion #212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #212 +/- ##
==========================================
+ Coverage 96.37% 96.37% +<.01%
==========================================
Files 51 51
Lines 2455 2457 +2
Branches 370 370
==========================================
+ Hits 2366 2368 +2
Misses 46 46
Partials 43 43
|
|
This seems representative of a parse/conversion error. I’m fine with this as a fix but I want to take a look at your test cases and figure out what’s going wrong. |
|
@uniqueiniquity i tried to setup this rule inside this project and i got a lot of false-positives with Syntax has no type in this case |
|
@uniqueiniquity Shall I wait to approve this so that you can look into it? I imagine that will make it easier to track? |
|
@JamesHenry looking now |
|
@armano2 @JamesHenry I've addressed the issue in in #226; it was an issue in convert after all :) |
kaicataldo
pushed a commit
to kaicataldo/typescript-eslint
that referenced
this pull request
Aug 27, 2019
…pescript-eslint#227) - correct url in no-misused-new - add tslint addontation to no-namespace - enable rules: eslint-plugin/no-deprecated-context-methods, eslint-plugin/prefer-output-null fixes: typescript-eslint#213 fixes: typescript-eslint#212
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rule crashes when i try to use it in this project